JabRef#4913 Bug - Downloads from the arXiv are marked as HTML files i…

…nstead of PDF may have found where to edit
benjagooder · Apr 25, 2019 · 96807fd · 96807fd
1 parent 5da1ee2
commit 96807fd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/main/java/org/jabref/logic/importer/fetcher/ArXiv.java b/src/main/java/org/jabref/logic/importer/fetcher/ArXiv.java
@@ -334,14 +334,14 @@ public ArXivEntry(Node item) {
                 if (linkTitle.equals(Optional.of("pdf"))) {
                     pdfUrlParsed = XMLUtil.getAttributeContent(linkNode, "href").map(url -> {
                         try {
+                            //#4913 bug
                             return new URL(url);
                         } catch (MalformedURLException e) {
                             return null;
                         }
                     });
                 }
             }
-            //#4913 bug
             pdfUrl = pdfUrlParsed;
 
             // Associated DOI

diff --git a/src/test/java/org/jabref/logic/importer/fetcher/ArXivTest.java b/src/test/java/org/jabref/logic/importer/fetcher/ArXivTest.java
@@ -66,6 +66,14 @@ public void findFullTextByDOI() throws IOException {
         assertEquals(Optional.of(new URL("http://arxiv.org/pdf/cond-mat/0406246v1")), finder.findFullText(entry));
     }
 
+    @Test
+    public void givenTestBibentry_whenfindFullText_thenFindFullTextByDOIWithPDFFileTypeSuffixAdded() throws IOException {
+        entry.setField(FieldName.DOI, "10.1529/biophysj.104.047340");
+        entry.setField(FieldName.TITLE, "Pause Point Spectra in DNA Constant-Force Unzipping");
+
+        assertEquals(Optional.of(new URL("http://arxiv.org/pdf/cond-mat/0406246v1.pdf")), finder.findFullText(entry));
+    }
+
     @Test
     public void findFullTextByEprint() throws IOException {
         entry.setField("eprint", "1603.06570");