forked from JabRef/jabref
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goml dev #33
Open
benjagooder
wants to merge
51
commits into
master
Choose a base branch
from
GOML-Dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Goml dev #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
benjagooder
commented
Apr 24, 2019
- Change in CHANGELOG.md described
- Tests created for changes
- Manually tested changed features in running JabRef
- Screenshots added in PR description (for bigger UI changes)
- Ensured that the git commit message is a good one
- Check documentation status (Issue created for outdated help page at help.jabref.org?)
… GOML-Dev merged in order to push changes
This system was not coded in a way condusive to integration testing, but I gave it a shot
Edited test names and moved some sut methods out of asserts.
Updated unit tests for milestone presentation
# Conflicts: # src/test/java/org/jabref/model/strings/StringUtilTest.java
Abbr1 and Style unit tests
finished unit tests for Style class
…erencesTest_GetSetAdditions Update SharedDatabasePreferencesTest.java
Author Class Unit Tests
Testing github methodology plus pushing logic.util.UpdateFieldPreferenceTest
Testing github methodology and pushing changes for logic.util
…nstead of PDF initial commit
…nstead of PDF may have found where to edit
…xed. After a file was added to a library, attempting to edit the file link in the General tab would throw an exception. It was fixed by only allowing an edit if a file was downloaded.
…xed. After a file was added to a library, attempting to edit the file link in the General tab would throw an exception. It was fixed by only allowing an edit if a file was downloaded.
Add option to copy the entire citation (currently copies author, title and year). "Copy citation" was added to Edit menu and to the right-click on the entry.
Add Copy Citation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.