Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kurtosis): Enable pprof in Kurtosis #886

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chuck-bear
Copy link
Collaborator

This PR will:

  • Enable pprof (cometbft) in Kusrtosis
  • Fix the broken sed in cometbft config

This PR will:
- Enable pprof (cometbft)  in Kusrtosis
- Fix the broken sed in cometbft config
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.25%. Comparing base (23498a9) to head (a521d79).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   14.25%   14.25%           
=======================================
  Files         182      182           
  Lines        8109     8109           
  Branches       16       16           
=======================================
  Hits         1156     1156           
  Misses       6888     6888           
  Partials       65       65           

@itsdevbear itsdevbear added this pull request to the merge queue Apr 24, 2024
@itsdevbear itsdevbear removed this pull request from the merge queue due to a manual request Apr 24, 2024
Copy link
Member

@itsdevbear itsdevbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test in testing/e2e that just makes an http request to make sure it can get the pprof data

@itsdevbear
Copy link
Member

Just to avoid regressions

@chuck-bear
Copy link
Collaborator Author

an http request to make sure it can get the pprof data

checking that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants