Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build successfully with clang #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thingkingland
Copy link

This is for ABC source code to build successfully by clang compiler. There are two issues.
1.

src/base/io/io.c:1470:5: error: implicit declaration of function 'unlink' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
unlink( pFileTemp );
^

The solution is to include a header

#include <unistd.h>
  1. There is a warning for each file

warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean
'-Wno-unused-const-variable'? [-Wunknown-warning-option]

The solution is to detect clang and do not add -Wno-unused-but-set-variable for clang in Makefile

@alanminko
Copy link
Contributor

alanminko commented Oct 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants