hardcoded queue prefix as constant #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
approved these changes
Feb 13, 2018
|
Thanks @bashilbers! |
|
Not good, merge freeze please until I sort the driver PR out. Now it's conflicting. :( |
|
Oh damn, I forgot about that! Sorry, I will wait with merges until further notice! |
|
Np, thanks. I will try to sort it out ASAP, but requires a lot of review to make sure nothing is screwed up. |
|
Yes I understand! If you need any help, just let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So you can extract the queue prefix for manual operations (so I don't have to inject a Driver and Producer in a component that actually produces and wants to do ->countMessages())