Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Jetty & use Netty #66

Closed
robfletcher opened this issue Sep 25, 2012 · 6 comments
Closed

Drop Jetty & use Netty #66

robfletcher opened this issue Sep 25, 2012 · 6 comments
Assignees
Labels
Milestone

Comments

@robfletcher
Copy link
Collaborator

Jetty's dependencies are a nightmare and the only real reason for using it is the fact that its lifecycle management is very good, i.e. it's very easy to tell when the proxy is ready to start receiving traffic. Vert.x would be every bit as good as it has callbacks that allow you to tell when a verticle is deployed and running.

This would mean Java 7+ only so I'd like to have a stable Betamax available for those using earlier Java versions before making this change. This will probably happen in the next major release.

@DeX77
Copy link

DeX77 commented Mar 11, 2013

+1 for this, since Betamax depending on Jetty messes with WebApps depending on it.

Perhaps I'll try myself porting.

@robfletcher
Copy link
Collaborator Author

After using Ratpack I think Netty is the way to go here. This should definitely be the priority for the next version of Betamax.

@ghost ghost assigned robfletcher Jul 31, 2013
robfletcher added a commit that referenced this issue Aug 3, 2013
the callbacks don't work the way I assumed. This is not a particularly good solution & needs something better
robfletcher added a commit that referenced this issue Aug 8, 2013
robfletcher added a commit that referenced this issue Aug 8, 2013
robfletcher added a commit that referenced this issue Aug 8, 2013
robfletcher added a commit that referenced this issue Aug 9, 2013
@lloydmeta
Copy link

👍 wasted a good hour today due to #61

@robfletcher
Copy link
Collaborator Author

HTTPS proxying is proving to be the hold up here. I'm having a lot of trouble getting it working in the same way it's currently working with Jetty. The HTTP side of the Netty implementation was very straightforward.

robfletcher added a commit that referenced this issue Sep 15, 2013
@robfletcher
Copy link
Collaborator Author

There's actually a very strong possibility of being able to use LittleProxy to do this. I had looked at that library before but it was using an older version of Netty and didn't have the API hooks I would need. However, they've just upgraded to Netty 4.0.7 and overhauled their API.

This would be a huge advantage for Betamax as the proxy code would be dropped in favor of using a library (presumably written by people who know a lot more about writing proxies than me).

Currently LittleProxy doesn't support SSL MITM but it used to before the upgrade and they're planning to re-add it – see adamfisk/LittleProxy#79

@rschmitt
Copy link
Contributor

Is this mature enough for a Maven release yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants