-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Jetty & use Netty #66
Comments
+1 for this, since Betamax depending on Jetty messes with WebApps depending on it. Perhaps I'll try myself porting. |
After using Ratpack I think Netty is the way to go here. This should definitely be the priority for the next version of Betamax. |
the callbacks don't work the way I assumed. This is not a particularly good solution & needs something better
👍 wasted a good hour today due to #61 |
HTTPS proxying is proving to be the hold up here. I'm having a lot of trouble getting it working in the same way it's currently working with Jetty. The HTTP side of the Netty implementation was very straightforward. |
There's actually a very strong possibility of being able to use LittleProxy to do this. I had looked at that library before but it was using an older version of Netty and didn't have the API hooks I would need. However, they've just upgraded to Netty 4.0.7 and overhauled their API. This would be a huge advantage for Betamax as the proxy code would be dropped in favor of using a library (presumably written by people who know a lot more about writing proxies than me). Currently LittleProxy doesn't support SSL MITM but it used to before the upgrade and they're planning to re-add it – see adamfisk/LittleProxy#79 |
Is this mature enough for a Maven release yet? |
Jetty's dependencies are a nightmare and the only real reason for using it is the fact that its lifecycle management is very good, i.e. it's very easy to tell when the proxy is ready to start receiving traffic. Vert.x would be every bit as good as it has callbacks that allow you to tell when a verticle is deployed and running.
This would mean Java 7+ only so I'd like to have a stable Betamax available for those using earlier Java versions before making this change. This will probably happen in the next major release.
The text was updated successfully, but these errors were encountered: