Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-req-dump could not get req.Client.IP #45

Closed
amane-ame opened this issue Apr 19, 2019 · 3 comments
Closed

http-req-dump could not get req.Client.IP #45

amane-ame opened this issue Apr 19, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@amane-ame
Copy link

Description of the bug or feature request

Environment

Please provide:

  • Bettercap version you are using ( bettercap -version ).
    2.23
  • OS version and architecture you are using.
    Ubuntu server 18.04.2 LTS
  • Go version if building from sources.
    1.12.4

Steps to Reproduce

  1. net.probe on
  2. set targets for arp.spoof
  3. arp.spoof on
  4. set certificate for https.proxy
  5. set https.proxy.script /usr/local/share/bettercap/caplets/http-req-dump/http-req-dump.js
  6. https.proxy on

Expected behavior: The script print the requests with client IP

Actual behavior: The script print the requests, but the client IP is empty

image

@amane-ame amane-ame changed the title https.proxy could not get req.Client.IP [Bug Report] https.proxy could not get req.Client.IP Apr 19, 2019
@evilsocket
Copy link
Member

@yungtravla if i recall correctly you changed something recently about this, any idea?

@evilsocket evilsocket transferred this issue from bettercap/bettercap Apr 22, 2019
@evilsocket evilsocket changed the title [Bug Report] https.proxy could not get req.Client.IP http-req-dump could not get req.Client.IP Apr 22, 2019
@evilsocket evilsocket added the bug Something isn't working label Apr 22, 2019
@buffermet
Copy link
Member

still debugging this but so far i can tell that req.RemoteAddr is not passed through requests in https.proxy. This issue does not seem to occur with http.proxy.

@amane-ame
Copy link
Author

I think the problem is in bettercap but not in caplets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants