Add missing StaticSystemParam::queue implementation. #14051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
the
C-Code-Quality
alice-i-cecile
approved these changes
Jun 27, 2024
alice-i-cecile
added
C-Bug
alice-i-cecile
added
D-Trivial
|
Merging as trivial. Thanks for spotting this! |
mockersf
pushed a commit
that referenced
this pull request
Jun 27, 2024
# Objective `StaticSystemParam` should delegate all `SystemParam` methods to the inner param, but it looks like it was missed when the new `queue()` method was added in #10839. ## Solution Implement `StaticSystemParam::queue()` to delegate to the inner param.
zmbush
pushed a commit
to zmbush/bevy
that referenced
this pull request
Jul 3, 2024
# Objective `StaticSystemParam` should delegate all `SystemParam` methods to the inner param, but it looks like it was missed when the new `queue()` method was added in bevyengine#10839. ## Solution Implement `StaticSystemParam::queue()` to delegate to the inner param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
StaticSystemParamshould delegate allSystemParammethods to the inner param, but it looks like it was missed when the newqueue()method was added in #10839.Solution
Implement
StaticSystemParam::queue()to delegate to the inner param.