Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement accessors #1900

Closed
wants to merge 2 commits into from
Closed

Implement accessors #1900

wants to merge 2 commits into from

Conversation

TheRawMeatball
Copy link
Member

This PR superceeds the monolithic #1393, and implements the core accessor api.

@TheRawMeatball TheRawMeatball mentioned this pull request Apr 12, 2021
Closed
@alice-i-cecile alice-i-cecile added A-Core Common functionality for all bevy apps A-ECS Entities, components, systems, and events C-Enhancement A new feature labels Apr 12, 2021
@mockersf
Copy link
Member

Very neat 👍
Could do with an example though

@zicklag zicklag mentioned this pull request Apr 16, 2021
Closed
@alice-i-cecile alice-i-cecile added the S-Needs-Design-Doc This issue or PR is particularly complex, and needs an approved design doc before it can be merged label Apr 23, 2021
@cart cart added the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 23, 2021
@mockersf mockersf removed the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 24, 2021
@alice-i-cecile alice-i-cecile removed the S-Needs-Design-Doc This issue or PR is particularly complex, and needs an approved design doc before it can be merged label Nov 17, 2021
@alice-i-cecile
Copy link
Member

@TheRawMeatball, do you still think this is useful? If so, could you add an example and update the PR description to be more helpful when you get a chance?

@alice-i-cecile alice-i-cecile added A-Tasks Tools for parallel and async work and removed A-Core Common functionality for all bevy apps labels Apr 25, 2022
@TheRawMeatball
Copy link
Member Author

It's actually probably not tbh, i'll just close the PR unless i need it, at which point i'd probably just reimplement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Tasks Tools for parallel and async work C-Enhancement A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheRawMeatball @mockersf @alice-i-cecile @cart