Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Switched the TODO comment in image_texture_conversion.rs #2981

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Switched the TODO comment in image_texture_conversion.rs #2981

wants to merge 5 commits into from

Conversation

billyb2
Copy link
Contributor

@billyb2 billyb2 commented Oct 16, 2021

Objective

The current TODO comment is out of date

Solution

I switched up the comment

@alice-i-cecile
Copy link
Member

As discussed in #2925.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 16, 2021
mockersf
mockersf requested changes Oct 16, 2021
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also change the comment in bevy_render2 in the pipelined directory?

bevy/pipelined/bevy_render2/src/texture/image_texture_conversion.rs

Line 90 in 43e8a15

// TODO unsafe_get in release builds?

@billyb2
Copy link
Contributor Author

billyb2 commented Oct 17, 2021

@mockersf got it!

@mockersf
Copy link
Member

Sorry for not reviewing everything at once...

Could you add back the between // and TODO? All the other todo comments are formatted like that in the repo.

Also could you mention in the comment the rust tracking issue for the feature? I guess it's rust-lang/rust#74985

@billyb2
Copy link
Contributor Author

billyb2 commented Oct 20, 2021

Is it looking good now?

@billyb2 billyb2 changed the title Siwtched the TODO comment in image_texture_conversion.rs Switched the TODO comment in image_texture_conversion.rs Oct 20, 2021
@mockersf
Copy link
Member

Also for the comment in pipelined/bevy_render2/src/texture/image_texture_conversion.rs 😃

@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 25, 2021
@billyb2
Switched the TODO comment in image_texture_conversion.rs (#2981)
9f47697 
# Objective

The current TODO comment is out of date

## Solution

I switched up the comment


Co-authored-by: William Batista <45850508+billyb2@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Oct 25, 2021

Pull request successfully merged into pipelined-rendering.

Build succeeded:

@bors bors bot changed the title Switched the TODO comment in image_texture_conversion.rs [Merged by Bors] - Switched the TODO comment in image_texture_conversion.rs Oct 25, 2021
@bors bors bot closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@NiklasEi NiklasEi NiklasEi approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@billyb2 @alice-i-cecile @mockersf @NiklasEi