[Merged by Bors] - Add reflection for resources #5175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Enhancement
|
Can you credit @Davier as a co-author in the PR description to make sure this gets into the release notes properly? :) |
alice-i-cecile
approved these changes
Jul 2, 2022
There was a problem hiding this comment.
Just like in the previous PR, I'm very happy that this exists and content with the underlying code.
Only thing I think this needs is basic docs on ReflectResource.
I won't block on this, but if you want to put more work into this PR:
- Docs on
ReflectResourcemethods. - Consider enabling reflection for more resource types.
PROMETHIA-27
suggested changes
Jul 2, 2022
|
Thanks for the tips. Updated the documentation. Please, take a look. |
|
Some thoughts for the future PRs:
|
alice-i-cecile
approved these changes
Jul 2, 2022
PROMETHIA-27
approved these changes
Jul 2, 2022
|
One final round of doc nits. I'll merge this on Monday during my weekly round :) |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
alice-i-cecile
approved these changes
Jul 2, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Can this be included here for consistency with the added |
|
No strong feelings. Feel free to include it if you'd like; reflection is getting basically a full rewrite in this release anyways. If you do, note it in the migration guide. |
|
Okay, thanks, done! |
alice-i-cecile
added
the
C-Breaking-Change
3 tasks
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
# Objective We don't have reflection for resources. ## Solution Introduce reflection for resources. Continues #3580 (by @Davier), related to #3576. --- ## Changelog ### Added * Reflection on a resource type (by adding `ReflectResource`): ```rust #[derive(Reflect)] #[reflect(Resource)] struct MyResourse; ``` ### Changed * Rename `ReflectComponent::add_component` into `ReflectComponent::insert_component` for consistency. ## Migration Guide * Rename `ReflectComponent::add_component` into `ReflectComponent::insert_component`.
bors
bot
changed the title
Forgot to push it :D |
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective We don't have reflection for resources. ## Solution Introduce reflection for resources. Continues bevyengine#3580 (by @Davier), related to bevyengine#3576. --- ## Changelog ### Added * Reflection on a resource type (by adding `ReflectResource`): ```rust #[derive(Reflect)] #[reflect(Resource)] struct MyResourse; ``` ### Changed * Rename `ReflectComponent::add_component` into `ReflectComponent::insert_component` for consistency. ## Migration Guide * Rename `ReflectComponent::add_component` into `ReflectComponent::insert_component`.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective We don't have reflection for resources. ## Solution Introduce reflection for resources. Continues bevyengine#3580 (by @Davier), related to bevyengine#3576. --- ## Changelog ### Added * Reflection on a resource type (by adding `ReflectResource`): ```rust #[derive(Reflect)] #[reflect(Resource)] struct MyResourse; ``` ### Changed * Rename `ReflectComponent::add_component` into `ReflectComponent::insert_component` for consistency. ## Migration Guide * Rename `ReflectComponent::add_component` into `ReflectComponent::insert_component`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective We don't have reflection for resources. ## Solution Introduce reflection for resources. Continues bevyengine#3580 (by @Davier), related to bevyengine#3576. --- ## Changelog ### Added * Reflection on a resource type (by adding `ReflectResource`): ```rust #[derive(Reflect)] #[reflect(Resource)] struct MyResourse; ``` ### Changed * Rename `ReflectComponent::add_component` into `ReflectComponent::insert_component` for consistency. ## Migration Guide * Rename `ReflectComponent::add_component` into `ReflectComponent::insert_component`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
We don't have reflection for resources.
Solution
Introduce reflection for resources.
Continues #3580 (by @Davier), related to #3576.
Changelog
Added
ReflectResource):