Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Relax Sync bound on Local<T> as ExclusiveSystemParam #7040

Closed
wants to merge 2 commits into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Dec 27, 2022

Objective

The type Local<T> unnecessarily has the bound T: Sync when the local is used in an exclusive system.

Solution

Lift the bound.


Changelog

Removed the bound T: Sync from Local<T> when used as an ExclusiveSystemParam.

@JoJoJet JoJoJet added A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use labels Dec 27, 2022
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is surprisingly useful!

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 27, 2022
@james7132 james7132 added this to the 0.10 milestone Jan 4, 2023
@alice-i-cecile
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Merge conflict.

@JoJoJet
Copy link
Member Author

JoJoJet commented Jan 9, 2023

bors retry

bors bot pushed a commit that referenced this pull request Jan 9, 2023
# Objective

The type `Local<T>` unnecessarily has the bound `T: Sync` when the local is used in an exclusive system.

## Solution

Lift the bound.

---

## Changelog

Removed the bound `T: Sync` from `Local<T>` when used as an `ExclusiveSystemParam`.
@bors bors bot changed the title Relax Sync bound on Local<T> as ExclusiveSystemParam [Merged by Bors] - Relax Sync bound on Local<T> as ExclusiveSystemParam Jan 9, 2023
@bors bors bot closed this Jan 9, 2023
@JoJoJet JoJoJet deleted the non-sync-exclusive-local branch January 10, 2023 03:26
james7132 pushed a commit to james7132/bevy that referenced this pull request Jan 21, 2023
…7040)

# Objective

The type `Local<T>` unnecessarily has the bound `T: Sync` when the local is used in an exclusive system.

## Solution

Lift the bound.

---

## Changelog

Removed the bound `T: Sync` from `Local<T>` when used as an `ExclusiveSystemParam`.
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
…7040)

# Objective

The type `Local<T>` unnecessarily has the bound `T: Sync` when the local is used in an exclusive system.

## Solution

Lift the bound.

---

## Changelog

Removed the bound `T: Sync` from `Local<T>` when used as an `ExclusiveSystemParam`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…7040)

# Objective

The type `Local<T>` unnecessarily has the bound `T: Sync` when the local is used in an exclusive system.

## Solution

Lift the bound.

---

## Changelog

Removed the bound `T: Sync` from `Local<T>` when used as an `ExclusiveSystemParam`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants