Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pnm textures #8601

Merged
merged 2 commits into from
May 17, 2023

Conversation

luca-della-vedova
Copy link
Contributor

Objective

Add support for the Netpbm image formats, behind a pnm feature flag.

My personal use case for this was robotics applications, with pgm being a popular format used in the field to represent world maps in robots.
I chose the formats and feature name by checking the logic in image.rs

Solution

Quite straightforward, the pnm feature flag already exists in the image crate so it's just creating and exposing a pnm feature flag in the root Cargo.toml and forwarding it through bevy_internal and bevy_render all the way to the image crate.


Changelog

Added

pnm feature to add support for pam, pbm, pgm and ppm image formats.

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@github-actions
Copy link
Contributor

You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.

@james7132 james7132 added this pull request to the merge queue May 16, 2023
Merged via the queue into bevyengine:main with commit a47f1ab May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants