Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin aiohttp #267

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Unpin aiohttp #267

merged 4 commits into from
Nov 6, 2023

Conversation

joostlek
Copy link
Contributor

@joostlek joostlek commented Nov 6, 2023

@joostlek joostlek mentioned this pull request Nov 6, 2023
Merged
20 tasks
@cdce8p
Copy link

cdce8p commented Nov 6, 2023

👍🏻 I would recommend to unlink setup.py requirements and requirements.txt. Both have different purposes. Whereas requirements.txt is often used for CI environments, setup.py just defines the lowest required version for a library to work. In this case it should probably just be

aiohttp>=3.7.0
orjson

@joostlek
Copy link
Contributor Author

joostlek commented Nov 6, 2023

I gave it an attempt

@cdce8p
Copy link

cdce8p commented Nov 6, 2023

I gave it an attempt

Looks good 👍🏻

bieniu
bieniu approved these changes Nov 6, 2023
View reviewed changes
Copy link
Owner

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joostlek @cdce8p

@bieniu bieniu merged commit 2f3cdcd into bieniu:master Nov 6, 2023
5 checks passed
@bieniu bieniu added the bugfix A fix for a bug label Nov 6, 2023
@joostlek joostlek deleted the unpin_aiohttp branch November 6, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bieniu bieniu bieniu approved these changes

Assignees
No one assigned
Labels
bugfix A fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joostlek @cdce8p @bieniu