This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Reintroduce subscripting ifNull/ifNotFound methods (with deprecation warnings) #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -539,3 +539,105 @@ extension JSON { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| // Deprecated methods. | |||
There was a problem hiding this comment.
Do you have feels about // MARK: - Deprecated methods?
There was a problem hiding this comment.
Yes, I feel it should be that.
|
I'm 👌 to merge. I vote that we remove the deprecated method calls from our tests. |
|
👍 Made both changes and removed the deprecated tests. Merge when travis is ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the
... ifNotFound: ...and... ifNull: ...subscripting methods to keep backwards compatibility. They are flagged as deprecated, with the message pointing to the new... alongPath: ...methods.This branch is currently pointed at the #148 branch. If that branch is merged first we can trivially rebase this onto master.
Downsides to this PR:
@availableis tied to OS version releases, so we use a flat@available(*, deprecated, ...). There are plans for library versioning, but it's not around yet.