This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Fixing missingKeyBecomesNil being recursive #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a fix for the
.missingKeyBecomesNil
Option catching errors from decode calls below.For instance:
If I were to call decode with the following invalid json:
{ "b": { } }
The previous implementation wouldn't throw an error but return
A(b: nil)
If you still want the previous functionality you can use the parameter
applyRecursively
.