Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect BACK button/gesture #77

Closed
licaon-kter opened this issue Dec 8, 2019 · 3 comments
Closed

Detect BACK button/gesture #77

licaon-kter opened this issue Dec 8, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@licaon-kter
Copy link
Contributor

...so the app doesn't stop sharing.

Eg. Maybe pop-up a dialogue with "are you sure you want to stop?" or have a Setting to either ignore BACK (minimize) or stop sharing and exit.

@bilde2910
Copy link
Owner

Wait, it actually stops the share? I'll admit I never actually tested that. It should not be that way and I'll definitely fix that Would probably have to put the specific behavior setting in the settings menu once #74 is done.

@bilde2910 bilde2910 added the bug Something isn't working label Dec 8, 2019
@licaon-kter
Copy link
Contributor Author

Yes, it might be ROM specific, more aggressive ones might choose to kill the app instead (in the name of battery savings).

@bilde2910
Copy link
Owner

The issue here was that clicking the back button would kill the Hauk UI but leave the session running in the background. When reopening the app, the UI would see that there was a share cached, but didn't see that the service was already running. It would then start a new session on top of the old one; the old one still pushed location which somehow caused the new one to not get a location fix. The patch makes the UI look for an existing running session instead and if it finds one, will silently stop the old session and resume the shares in a new session.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants