Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the UI #74

Closed
licaon-kter opened this issue Dec 8, 2019 · 17 comments
Closed

Rework the UI #74

licaon-kter opened this issue Dec 8, 2019 · 17 comments
Labels
enhancement New feature or request

Comments

@licaon-kter
Copy link
Contributor

licaon-kter commented Dec 8, 2019

...no mockups yet as I'm not a UI/UX designer.

But:

  • there are a lot of input fields
  • some of them could be hidden behind buttons, eg. server/pass, how often do you change that?
  • some are hidden but once revealed (e2e stuff) you can't actually hide them back
  • the whole input part could be hidden once sharing has started (eg. and make the countdown clock bigger), also those fields are already disabled anyway, right? Eg. make them enabled/pop-up if I hit Share again.
  • the logo on top occupies too much space, yes you have the icon in the titlebar, move the github link there, make it clickable, use the view space for something useful.
  • dark theme (yes my Android actually forces a dark theme, but not all users run Android 10)
  • ...
@bilde2910
Copy link
Owner

I agree on these points. I'm no UI/UX designer either, but I think it's time for me to move some stuff to a separate "settings" screen that can be accessed from a menu in the top-right corner. That will allow me to fit a lot of different settings in there as well in addition to those I already have.

Plus it will make for a much cleaner interface. I'll look at it and see what I can do, but it'll be a big undertaking, so I'll hope to have some progress on this in v1.6 rather than the upcoming v1.5.2. (Or I could skip right to v1.6.)

@bilde2910 bilde2910 added the enhancement New feature or request label Dec 8, 2019
@licaon-kter
Copy link
Contributor Author

Move the STOP button on top, having gestures enabled I find myself touching the lower part of the screen rather often.

@bilde2910
Copy link
Owner

Here's current progress on moving settings to a separate menu, opened from the cog icon on the toolbar.

hauk-settings-menu

bilde2910 added a commit that referenced this issue Dec 11, 2019
@licaon-kter
Copy link
Contributor Author

Open Settings on first start, don't allow dismissing the Settings if Server is empty and there is no Password (at least)

Default Update interval, make it longer eg. 3-5 seconds, users might not bother setting it up and 1 sec is rather aggressive, battery wise.

If Group share, don't start if there's no Nickname setup.

@bilde2910
Copy link
Owner

I can set it up so that if the user presses "Start" when there is no server URL set, instead of starting the share, the Settings menu shows up and a toast notification informs them that they have to set a server URL before they can start sharing.

@licaon-kter
Copy link
Contributor Author

Touching the logo/github link should open that link.

Add in Settings a last section with app version (and server version if such thing is possible)

@licaon-kter
Copy link
Contributor Author

The button layout is rather picky, I had Stop translated as Oprire, so the button had OPRI and RE on the second row, so I changed it to Stop (same meaning in many languages) only to find it rendered like this now:

buttonlayout

The strange part is that after some time (open, minimize the app), the button stretches to have the full word.

Can this layout be more flexible, to encompass the words fully if enough space is available?

@bilde2910
Copy link
Owner

bilde2910 commented Dec 13, 2019

I'm honestly not sure why that happens. It started after the first rework commit. I'm hoping that as I move the list of active shares away from the main UI in #72, this will resolve itself. Otherwise I'll have to dig a bit more to see what's causing this to happen.

I can also confirm this happens on English locale where it says "STO P" and "SHA RE" for these buttons.

bilde2910 added a commit that referenced this issue Dec 13, 2019
bilde2910 added a commit that referenced this issue Dec 13, 2019
@bilde2910
Copy link
Owner

Current status:

✔️ there are a lot of input fields
✔️ some of them could be hidden behind buttons, eg. server/pass, how often do you change that?
✔️ some are hidden but once revealed (e2e stuff) you can't actually hide them back

Resolved by moving these to the new settings menu

❌ the whole input part could be hidden once sharing has started (eg. and make the countdown clock bigger), also those fields are already disabled anyway, right? Eg. make them enabled/pop-up if I hit Share again.
❌ the logo on top occupies too much space, yes you have the icon in the titlebar, move the github link there, make it clickable, use the view space for something useful.

Now that the other input fields are gone, do you think these are still necessary? There's no longer any need to scroll down to see all the UI elements on the main page

✔️ dark theme (yes my Android actually forces a dark theme, but not all users run Android 10)

Resolved by the past few commits

❌ Move the STOP button on top, having gestures enabled I find myself touching the lower part of the screen rather often.

Connection settings have all been moved to the settings page, so the stop button is higher up now. Also wondering if maybe #78 could be a better solution here. However, I don't use gestures myself. What are your thoughts about this in light of the recent changes? I can't really comment much since I don't use gestures

✔️ Open Settings on first start, don't allow dismissing the Settings if Server is empty and there is no Password (at least)

Resolved via toast notification

❌ Default Update interval, make it longer eg. 3-5 seconds, users might not bother setting it up and 1 sec is rather aggressive, battery wise.

I realized I never actually commented on this. The device will use a lot of battery power for location services if the interval is set to 3 seconds too (maintaining a fix). 1 second was chosen because it provides the smoothest real-time view on the map given that there is currently no movement prediction on the frontend. I'm not really inclined to change this default right now

❌ If Group share, don't start if there's no Nickname setup.
❌ Touching the logo/github link should open that link.

To be implemented

❌ Add in Settings a last section with app version (and server version if such thing is possible)

Good idea. Server version is returned by the server while a share is active, but actually accessing it in the settings menu will be difficult. I can certainly show the app version, though. To be implemented

❌ Can this layout be more flexible, to encompass the words fully if enough space is available?

To be analyzed and fixed

@licaon-kter
Copy link
Contributor Author

Now that the other input fields are gone, do you think these are still necessary? There's no longer any need to scroll down to see all the UI elements on the main page

I guess not

Connection settings have all been moved to the settings page, so the stop button is higher up now.

#78 is the fix yes.

I can't really comment much since I don't use gestures

Gestures are a mainstay since Android 9, but I never managed to touch the button anyway, just that it "looks dangerous", again #78 will make this a moot point.

@licaon-kter
Copy link
Contributor Author

Notification - show current/real status: "Location active" or "Searching location/GNSS", now it's always "active"

@bilde2910
Copy link
Owner

bilde2910 commented Dec 25, 2019

Current status:

✔️ If Group share, don't start if there's no Nickname setup.
✔️ Touching the logo/github link should open that link.

Done.

✔️ Add in Settings a last section with app version (and server version if such thing is possible)

App version shown, along with link to source code and issue tracker.

✔️ Can this layout be more flexible, to encompass the words fully if enough space is available?

Seems to be an Android bug causing this issue. Workaround live in latest commit; resolved, for all intents and purposes.

❌ Notification - show current/real status: "Location active" or "Searching location/GNSS", now it's always "active"

To be implemented. I'm thinking some kind of configurable "time since last update" setting, i.e. fall back to coarse location again ("waiting for high-accuracy fix") if no accurate location has been received for e.g. 45 seconds since the last time it should have been received. What are your thoughts about this, and what do you think a sane default would be here?

Would it also be a good idea to show inaccurate, non-GNSS locations on the map in yellow or some other coloring instead of red?

@licaon-kter
Copy link
Contributor Author

I'm thinking some kind of configurable "time since last update" setting,

I have no thoughts here, 45 secs sounds ok

Would it also be a good idea to show inaccurate, non-GNSS locations on the map in yellow or some other coloring instead of red?

Yes, please, I've seen some large (half the city) jumps in some cases so making these stand out helps.

@bilde2910
Copy link
Owner

✔️ Notification - show current/real status: "Location active" or "Searching location/GNSS", now it's always "active"
✔️ Would it also be a good idea to show inaccurate, non-GNSS locations on the map in yellow or some other coloring instead of red?

Implemented in latest commit. The status switches over automatically after (interval + timeout) time, where interval is your session's interval, and timeout defaults to 45 seconds but is configurable in settings.

All items in this issue are now resolved; closing. Thanks a lot for your suggestions! If there's anything else, feel free to create new issues 👍

@licaon-kter
Copy link
Contributor Author

Umm

Notification - show current/real status: "Location active" or "Searching location/GNSS", now it's always "active"

This is not fixed, the actual notification text is not in sync with in app location status. If app is "Searching for location..." the notification should mirror that state.

@bilde2910
Copy link
Owner

Oh, I fixed the wrong thing apparently. I'll try to fix the notification as well.

@bilde2910
Copy link
Owner

There, that should fix it :-)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants