Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: support redis #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximbaz
Copy link
Contributor

@maximbaz maximbaz commented Nov 9, 2020

This adds php extensions for redis, so that a user can choose to use redis without having to recompile hauk image as well.

@bilde2910
Copy link
Owner

The intent of the Docker image was to bundle a production-ready Hauk installation together with memcached, so that the user doesn't need to have any dependencies on other containers. Though it does make sense that a Hauk container supports all the plugins and storage options, if the hoster decides to use an external solution instead. Perhaps it would also make sense to at some point remove the bundled memcached service entirely, or offer a separate Docker image tag that excludes memcached.

I'll await merging this because I need to test building the image, and make sure that adding redis via PECL doesn't require additional dependencies to be installed via apt, as if so, I need to add those dependencies to the Dockerfile to ensure that all the dependencies are present before the extension is built.

@bilde2910 bilde2910 added the enhancement New feature or request label Nov 12, 2020
@maximbaz
Copy link
Contributor Author

Yeah I realized the purpose of the image, but I wanted to use redis on my own server instead of memcached, and this simple change allowed me to do it 😉 I agree it would be cool to provide a separate tag without bundled memcached, but honestly I don't care too much - this change alone works well 👍 Once you try this out as well, let me know if you spot anything, I will be happy to assist further 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants