Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Metric: Altitude #168
base: master
Are you sure you want to change the base?
New Metric: Altitude #168
Changes from 8 commits
f550c13
6c788e3
13b6664
6b556c1
8fd96ba
24750a3
9cbd1cc
b5dad6e
082da40
27a1959
4ae423a
33e19cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would probably feel a bit more compact if we add the altitude as a line underneath the velocity instead of on the same line.
Also suggest changing
line-height
from 100% to 125% in.marker p
in main.css to make this two-line layout look better/more spaced out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good idea. In fact I tried that first, but the alignment between speed and altitude looked awful. I need to brush up on my CSS skills a bit but I'll come up with something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest adding something that indicates that the metric shown is the altitude. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In aviation you would probably expect something like "250m AMSL", which indicates 250m above mean sea level. But that would probably look a bit odd below the speed:
12.5 km/h
250 m AMSL
I'll come up with something that looks good (hopefully), I just need to try out some ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing width from 66px to 74px to accommodate the extra rounding caused by moving altitude to its own line.