Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes #48

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Changes #48

wants to merge 9 commits into from

Conversation

packt-joeld
Copy link

No description provided.

@binarymist
Copy link
Owner

binarymist commented Jul 1, 2017

Waiting for the rest of the issues to be addressed as per email:

Just thinking also, the references to "Fascicle n" we have (there will be quite a few), if we're changing the names of the book parts (Ben mentioned using the Part n format, check with him), then we will also need to change these. There is also other text you're changing

the "formulate their exploits for you refer the sub-section" needs to be "formulate their exploits for you, refer to the sub-section"

Point 20 still isn't addressed. If this needs to be in there, why not add these changes to a new branch of your fork -> issue pull request to the upstream packt branch.

Point 22 in regards to the indentation, still needs to be less nested (2 or more characters less).

Point 25 still needs to be done. "A 10,000' view scenario" should be "A 10,000' View Scenario", again as per source. "4. SSM risks that Solution Causes" should be "4. SSM Risks that Solution Causes". "5. SSM Costs and Trade-offs"

I am noticing some inconsistencies in our list item full stop rational, I've just checked this with Russ, I'll let you know the outcome once I get a response. No full stops at the end of list items ever.

See answers inline.................

Hey kim,

Thanks for the highlighting these issues Kim,

I will stick as close to the source as possible if any changes I will mark it on Github, I have so already committed changes for Chapter 3 and this morning for 1 as well. In licensing process we usually indent books as per packt standards. But as you know we are an Author-led team within Packt. We don't mind going an extra mile and adapt to author requirements, sometimes working late into the wee hours. Our only focus right now is to get this book published before the end of this month. The following changes have been addressed.

  1. The (') symbol in the chapter title had been removed due to some technical glitch in our content platform.

[KC] Looks like it's still glitching, 30000' is supposed to have a ',' (comma)

That would be anyways looked after when we do our final checks we check all the chapter references and heading levels in the TOC and all over the book.

2)The black box around the images have been removed as per your preference.

3)We give an ordered list to a content explaining a sequence or a procedure. Else we mark it as normal bullets. I have changed it numbered bullets as per your requirement.

4)While Editing book as per packt standards we don't keep any other style within a block quote so I had removed the bold Markup. I have changed it back to bold.

[KC] Thanks, but it is no longer italicised. Can we have it the same format but bold, not a different format and bold?

5)The link have been applied as they were in the source. in 1. SSM & 2. SSM

6)The indentation under likelihood has been fixed. There were issues with content development platform. I agree that was way too much indentation.

[KC] They are still about two characters too deep. When you get to the next book part, and we have deeper nesting, this becomes really important, and we really need to stick with the same depth right throughout the book series. This is still observed in my point 18. Please pull them out at least two characters.

7)Intel Threat Agent Library Changed to how it was. We usually add an article before an object. I have removed "The" from the sentence.

[KC] No now you have two the's "and the the Intel Threat Agent Library"

8)"MicroSoft 6. Rate the Threats Link reapplied to how it was before.

9)The I icon for the information box around the link has been added.

10)We normally add full stops to Bullet lists when there are two sentences within one bullet separated by a comma or another full stop. I have removed the full stop across
bullets as it something you prefer.

[KC] But you haven't. Point 27 "The first list in 30,000' chapter has added full stops".

@binarymist
Copy link
Owner

Have removed all full stops at end of list items. Please fetch -> merge latest before making additional changes.
https://github.com/binarymist/HolisticInfoSec-For-WebDevelopers-Fascicle0/commits/master

@binarymist
Copy link
Owner

Please resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants