-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update breseq to v0.32.1 #9344
Update breseq to v0.32.1 #9344
Conversation
corburn
commented
Jun 13, 2018
- I have read the guidelines for bioconda recipes.
- This PR adds a new recipe.
- AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
- This PR updates an existing recipe.
- This PR does something else (explain below).
There are a few different ways you can deal with recipes that require samtools and co, and it depends on what the recipe needs. If it needs to just link against the library you can include samtools as a build/runtime dep, and patch the makefile to tell it not to try and compile samtools. If it needs some file from samtools/htslib distros that are not included in the conda package (it happens sometimes), you will have to go through, find all the makefiles for samtools and co, and make sure they match the makefiles in bioconda. The first option is less painful and preferable when it can be used. ;-) |
The json library this require is not compatible with gcc 4.8, which is what we have. I think this version of gcc has some backports that may fix whatever it doesn't like, so maybe add a patch to the json.hpp so that it won't throw that error? That is a total hack, but it may work. |
Possibly patch libbreseq/json.hpp ?
|
This needs to be patched: I think it might work with the linux-anvil gcc. It has some backports from 4.9 to fix stuff (I think). |
just in time for conda build 3! |
70ab9dd
to
eb78c2e
Compare
08af2ee
to
08fc11d
Compare