Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql_formatter): implement graphql formatter #3296

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

denbezrukov
Copy link
Contributor

Summary

  • Added prettier snapshots
  • Implement almost all nodes.

Test Plan

cargo test

@github-actions github-actions bot added the A-Formatter Area: formatter label Jun 26, 2024
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy crap, that escalated quickly! :D

I didn't check all the snapshots, but this is great work! Also quite educational, since it showed me how much of the formatting is handled by Biome's formatting infrastructure already.

Gives me hope for the GritQL formatter too :)

f,
[group(&format_args![
l_curly_token.format(),
soft_block_indent_with_maybe_space(&members.format(), true), // TODO implement options.bracket_spacing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@github-actions github-actions bot added the A-Parser Area: parser label Jun 27, 2024
@denbezrukov denbezrukov merged commit 2244c0b into feat/graphql-formatter Jun 27, 2024
5 checks passed
@denbezrukov denbezrukov deleted the feat/graphql-formmater-prettier branch June 27, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter A-Parser Area: parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants