Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(noUnusedVariables): don't report unused function params #3598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(noUnusedVariables): don't report unused function params #3598

wants to merge 1 commit into from
+89 −387

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Aug 6, 2024 •
edited
Loading

Summary

Close #3596

Test Plan

I updated the tests.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Aug 6, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 6, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3598 will not alter performance

Comparing conaclos/noUnusedVariables-dont-report-unused-params (70bdcd2) with main (2f8a37f)

Summary

✅ 99 untouched benchmarks

ematipico
ematipico requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, not a new feature. We can't merge these changes unless we intend to ship v2.0

The only thing we can do is to deprecate this rule for now.

@Conaclos Conaclos force-pushed the conaclos/noUnusedVariables-dont-report-unused-params branch from ce12d8a to 70bdcd2 Compare August 6, 2024 12:44
@ematipico ematipico added this to the Biome 2.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico requested changes

@dyc3 dyc3 dyc3 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
Biome 2.0
Development

Successfully merging this pull request may close these issues.

lint/correctness/noUnusedVariables errors on unused function params
3 participants
@Conaclos @ematipico @dyc3