Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support OpenBSD #3707

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: support OpenBSD #3707

wants to merge 1 commit into from

Conversation

neezer
Copy link

@neezer neezer commented Aug 23, 2024

Use std::alloc::System for OpenBSD as jemalloc is not supported.

NOTE: I'm only 80% sure this works, as I was unable to finish compiling this on my OpenBSD laptop: I got all the way to 603/617 and then ran out of memory (my laptop is pretty ancient... like from 2012.) I'd love it if someone who has a beefier OpenBSD box could give this a spin.

TODO

  • Verify build completes on OpenBSD
  • Update GHA to build OpenBSD artifacts

closes #3672

Use `std::alloc::System` for OpenBSD as `jemalloc` is not supported.

NOTE: I'm only 80% sure this works, as I was unable to finish compiling this on
my OpenBSD laptop: I got all the way to 603/617 and then ran out of memory (my
laptop is pretty ancient... like from 2012.) I'd love it if someone who has a
beefier OpenBSD box could give this a spin.

I'm also unsure if there are other parts of the repo that need to be updated to
ensure OpenBSD artifacts get built and distributed accordingly. Happy to make
changes to support that if folks could point me in the right direction.

closes biomejs#3672
@github-actions github-actions bot added A-CLI Area: CLI A-Tooling Area: internal tools labels Aug 23, 2024
@nhedger
Copy link
Member

nhedger commented Aug 23, 2024

Since we're going to build it in GHA anyway, I think the PR should update the workflow to build it on openbsd. Not sure about support of openbsd in GitHub actions though.

@dyc3
Copy link
Contributor

dyc3 commented Aug 23, 2024

These might be worth looking into for CI, since bsd is not supported natively in github actions:

@neezer
Copy link
Author

neezer commented Aug 23, 2024

@nhedger Ok, I can take a stab at updating the GHA. Having not done this before, are there any guides about how I can test my changes locally? I found act and was trying that, but ...

act -W .github/workflows/release_cli.yml --container-architecture linux/amd64

... is failing on "Run Main Check version changes" and I'm not entirely sure why yet. 🤔

I checked CONTRIBUTING.md and I didn't see anything in there about making updates to GHA. Would appreciate any guidance you could throw my way. 😄 The links @dyc3 provided look very promising, at first glance.

@neezer neezer marked this pull request as draft August 23, 2024 23:06
@dyc3
Copy link
Contributor

dyc3 commented Aug 23, 2024

For testing new github actions, I would recommend testing them on your fork of the repo. You'll need to change the trigger condition so that it runs on push so that it runs when you push to your branch (perhaps on a different branch than this one, so we don't get pinged in our notifs when you push).

Once you are done, you can update this branch with the new actions and we can go from there.

@neezer
Copy link
Author

neezer commented Aug 23, 2024

For testing new github actions, I would recommend testing them on your fork of the repo.

Is that free for me to do? Or would I have to pay GitHub to run those?

@dyc3
Copy link
Contributor

dyc3 commented Aug 23, 2024

Yup, github runs all open source CI for free.

@neezer
Copy link
Author

neezer commented Aug 23, 2024

@dyc3 How would I verify if my changes work? I'm guessing I'd look for the uploaded artifact defined here but where would I find that, once the action completes?

@dyc3
Copy link
Contributor

dyc3 commented Aug 24, 2024

You'd check your repo's action runs: https://github.com/neezer/biome/actions to see if it succeeded. This appears to be your latest run: https://github.com/neezer/biome/actions/runs/10534020638/job/29191019446

@ematipico
Copy link
Member

@neezer are you still interested in this PR?

@neezer
Copy link
Author

neezer commented Sep 19, 2024

@ematipico Yes, I'm blocked waiting for the ability to build OpenBSD snapshots in Github Actions, as that's the only way to get the required version of Rust available in a runner to build Biome... though at this rate, 7.6 will probably release soon, which might negate the (immediate) need for snapshots... unless y'all updated Biome to use a feature requiring Rust > v1.80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants