Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve version detection #41

Merged
merged 5 commits into from
Jan 13, 2024

Conversation

nhedger
Copy link
Member

@nhedger nhedger commented Jan 13, 2024

This PR introduces improvements to the automatic version detection strategy.

  • The action will now fall back to package.json for detecting the version if there are no lock files or if the lock file cannot be parsed (e.g., bun's binary bun.lockb file).

  • When reading the version from package.json, and if the version is specified as a semver range, the action will resolve it to the highest version within that range.

Here's a flow diagram that explains how the resolution works.

diagram-export-13-01-2024-12_12_53


Closes #40

@nhedger nhedger force-pushed the nhedger/feat/improve-version-detection branch from 1324201 to 49c9587 Compare January 13, 2024 14:29
@nhedger nhedger marked this pull request as ready for review January 13, 2024 17:28
@nhedger nhedger merged commit 7702017 into main Jan 13, 2024
20 checks passed
@nhedger nhedger deleted the nhedger/feat/improve-version-detection branch January 13, 2024 17:32
@nhedger nhedger changed the title feat: improve automatic version detection feat: improve version detection Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read version from bun.lockb binary file
1 participant