Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French translation #223

Merged
merged 2 commits into from
Sep 3, 2019
Merged

Add French translation #223

merged 2 commits into from
Sep 3, 2019

Conversation

huey735
Copy link
Member

@huey735 huey735 commented Aug 28, 2019

No description provided.

@huey735 huey735 mentioned this pull request Aug 28, 2019
@m52go
Copy link
Contributor

m52go commented Aug 29, 2019

@huey735 would you mind removing the outdated_translation references, since they are part of #220?

All you have to do is switch to your addFrTranslations branch with git checkout addFrTranslations, remove all references to outdated_translation, commit, and then push.

Then this PR will automatically reflect the changes -- no need for another PR.

@huey735
Copy link
Member Author

huey735 commented Aug 29, 2019

@m52go what references? The variables in the front matter? The ones from this PR are not present in #220 as French wasn't included in that PR.

@m52go
Copy link
Contributor

m52go commented Aug 31, 2019

@huey735 yes, the ones from the front matter. It's ok if they're not in the other PR...we can add them in another PR.

@m52go
Copy link
Contributor

m52go commented Sep 3, 2019

ACK

@m52go m52go merged commit 78e261c into bisq-network:master Sep 3, 2019
@huey735 huey735 deleted the addFrTranslations branch September 3, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants