Add automated workflow for transifex updates #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 9, 2020 11:51
Scripts in .tx/ fetch translations from Transifex, update _data/<lang>.yml files, and update SVG files.
|
Would be willing to test scripts. But I won't be able to review until sometime next week. |
This was referenced Aug 21, 2020
Doesn't work with new SVGs. Was janky anyway, so don't see point in re-doing it.
|
@Bayernatoor thanks for the offer. I had to remove the SVG update script, so there isn't much left to test that isn't closely tied to Transifex. I'll merge this PR upon testing it with a real update from Transifex. |
m52go
added a commit
to m52go/bisq-website
that referenced
this pull request
Jul 29, 2021
These were used in a script written last year (see bisq-network#386) to automate translations updates, but the image update part didn't turn out well. Therefore these strings are no longer necessary.
|
I'm closing this PR for now. You can re-open it when it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a much-needed automated workflow for integrating updates on Transifex to this Jekyll website, building on groundwork pushed earlier this week (e.g., consolidated yml files).
NOTE: this workflow will only work once the updated XML attributes from #385 are also merged. To test this PR, you'll need to merge that PR with this one (and obtain a Transifex API key for the
bisq-websiteproject). I may just merge this PR after that one is merged since (1) it is unlikely that anyone will actually be able to test this PR and (2) nothing in this PR affects the rendering of the website. Still, I will leave it open for a few days for feedback.The workflow:
_data/<lang>.ymlAs a result of this update, all translation work for the website must only occur on Transifex. Anyone with a Transifex API key (i.e., Transifex admin) can apply updates by running
.tx/update-translations.sh.This PR finally makes it feasible to document the localization process (#244), specifically:
When complete, I'll post the relevant wiki links in #244.
Review Guidance
As mentioned above, reviewing this pull request fully is difficult because of limited access to Transifex.
With that said, for anyone who is interested in testing the proposed scripts, I can send a raw dump of Transifex files to get around that issue. It's the scripts we want to test anyway, not Transifex's API :)