Skip to content

Commit

Permalink
Fix2 - Explain why bitcoinSerialize(false) is used
Browse files Browse the repository at this point in the history
  • Loading branch information
oscarguindzberg committed Oct 26, 2020
1 parent 27519c4 commit 46c7d9e
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1174,7 +1174,9 @@ private RawTransactionInput getRawInputFromTransactionInput(@NotNull Transaction
checkNotNull(input.getValue(), "input.getValue() must not be null");

// bitcoinSerialize(false) is used just in case the serialized tx is parsed by a bisq node still using
// bitcoinj 0.14. The serialized tx is just used to obtain its hash, so the witness data is not relevant.
// bitcoinj 0.14. This is not supposed to happen ever since Version.TRADE_PROTOCOL_VERSION was set to 3,
// but it costs nothing to be on the safe side.
// The serialized tx is just used to obtain its hash, so the witness data is not relevant.
return new RawTransactionInput(input.getOutpoint().getIndex(),
input.getConnectedOutput().getParentTransaction().bitcoinSerialize(false),
input.getValue().value);
Expand Down

0 comments on commit 46c7d9e

Please sign in to comment.