Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find push solution for order publishing #1

Closed
bisq-network opened this issue Jun 10, 2014 · 2 comments
Closed

Find push solution for order publishing #1

bisq-network opened this issue Jun 10, 2014 · 2 comments
Labels
in:network

Comments

@bisq-network
Copy link
Collaborator

We use polling at the moment, but a push based solution (multicast like) would be better. No concrete idea yet how to impl. that based on TomP2P.
@bisq-network bisq-network added this to the Basic usecases with P2P network version 0.2 milestone Jun 10, 2014
@cbeams cbeams modified the milestones: M4, v1.0.0 Sep 29, 2014
@btcll btcll mentioned this issue Oct 10, 2014
Closed
@cbeams
Copy link
Member

cbeams commented Oct 11, 2014

@ManfredKarrer is this issue still critical for v0.1?

@cbeams
Copy link
Member

cbeams commented Oct 11, 2014

@ManfredKarrer is this issue still critical for v0.1?

Nevermind—I was misreading the milestone here as v0.1, when it's actually v1.0.

@ManfredKarrer ManfredKarrer removed this from the v1.0 milestone Nov 29, 2014
@ManfredKarrer ManfredKarrer changed the title Use broadcast/multicast for order publishing Find push solution for order publishing Nov 29, 2014
@cbeams cbeams removed the p4 label Dec 18, 2014
@krynne krynne mentioned this issue Jul 20, 2016
Closed
ManfredKarrer pushed a commit that referenced this issue Oct 18, 2016
@haiqu
Merge pull request #1 from layer1gfx/patch-1
78812d7 
Update German translation
@ElLamparto ElLamparto mentioned this issue Jul 6, 2017
Closed
@llhoppy llhoppy mentioned this issue Jan 3, 2018
Closed
ManfredKarrer pushed a commit that referenced this issue Feb 13, 2018
@ghubstan
Merge pull request #1 from bisq-network/master
c8283af 
Bringing my fork up to date
sqrrm referenced this issue in sqrrm/bisq-desktop Jun 19, 2018
@ManfredKarrer
Merge pull request #1 from sqrrm/periodservice-cycles
7cf9935 
Periodservice cycles
ManfredKarrer referenced this issue in ManfredKarrer/bisq Oct 20, 2018
@blabno
Merge pull request #1 from ManfredKarrer/http-api
3f5004b 
Integration and refactorings
@BravoIndia BravoIndia mentioned this issue Dec 6, 2018
Closed
ManfredKarrer referenced this issue in ManfredKarrer/bisq Dec 19, 2018
@craigsailor
Merge pull request #1 from bisq-network/master
1b86fcc 
Wednesday update
@Sylo44 Sylo44 mentioned this issue Jan 22, 2019
Closed
@wiz wiz mentioned this issue Sep 2, 2019
Closed
@RHANDP RHANDP mentioned this issue Sep 18, 2019
Closed
bodymindarts pushed a commit to bodymindarts/bisq that referenced this issue Nov 19, 2019
@chimp1984
Merge pull request bisq-network#1 from wiz/grpc
9066909 
Compilation fixes
@mercurytoxic mercurytoxic mentioned this issue Nov 25, 2019
Closed
@BolivarcoinXT BolivarcoinXT mentioned this issue Dec 10, 2019
Closed
sqrrm pushed a commit that referenced this issue May 26, 2020
@dmos62
Fix forgotten break in switch statement #1
58db561 
This omission is currently not disruptive, since the next case clause only contains a break.
ghubstan referenced this issue in ghubstan/bisq Jun 13, 2020
@ghubstan
Add rpc method 'getfundingaddresses'
85c9676 
This addresses task #1 in issue bisq-network#4257.

This new gRPC WalletService method displays the BTC wallet's list of
receiving addresses.  The balance and number of confirmations
for the most recent transaction is displayed to the right of each
address.  Instead of returning a gRPC data structure to the client,
the service method returns a formatted String.

If the BTC wallet has no unused addresses, one will be created and
included in the returned list, and it can be used to fund the wallet.

The new method required injection of the BtcWalletService into CoreWalletsService,
and the usual boilerplate changes to grpc.proto, CliMain, and GrpcWalletService.

Some of the next PRs (for bisq-network#4257) will require some common functionality within
CoreWalletsService, so these additional changes were included:

  * a private, class level formatSatoshis function
  * a public getNumConfirmationsForMostRecentTransaction method
  * a public getAddressBalance method
  * a private getAddressEntry method

A unit test that verifies a successful return status was added to cli/test.sh.
eigentsmis pushed a commit to eigentsmis/bisq that referenced this issue Jun 26, 2020
@ghubstan @eigentsmis
Add rpc method 'getfundingaddresses'
6ec18a5 
This addresses task bisq-network#1 in issue bisq-network#4257.

This new gRPC WalletService method displays the BTC wallet's list of
receiving addresses.  The balance and number of confirmations
for the most recent transaction is displayed to the right of each
address.  Instead of returning a gRPC data structure to the client,
the service method returns a formatted String.

If the BTC wallet has no unused addresses, one will be created and
included in the returned list, and it can be used to fund the wallet.

The new method required injection of the BtcWalletService into CoreWalletsService,
and the usual boilerplate changes to grpc.proto, CliMain, and GrpcWalletService.

Some of the next PRs (for bisq-network#4257) will require some common functionality within
CoreWalletsService, so these additional changes were included:

  * a private, class level formatSatoshis function
  * a public getNumConfirmationsForMostRecentTransaction method
  * a public getAddressBalance method
  * a private getAddressEntry method

A unit test that verifies a successful return status was added to cli/test.sh.
@Shic1983 Shic1983 mentioned this issue Sep 18, 2020
Closed
@GIJack GIJack mentioned this issue Oct 25, 2020
Closed
@ghubstan ghubstan mentioned this issue Oct 27, 2020
Merged
@asolopovas asolopovas mentioned this issue Apr 1, 2021
Closed
ripcurlx added a commit that referenced this issue Jan 10, 2022
@ripcurlx
Merge pull request #5951 from ghubstan/rename-keepfunds2closetrade
6c80225 
Rename API method keepfunds -> closetrade (#1)
ripcurlx added a commit that referenced this issue Feb 14, 2022
@ripcurlx
Merge pull request #6042 from ghubstan/1-clean-protobuf-comments
b44a562 
Modify .proto file comments to be parsed by bisq-grpc-api-doc [#1]
ripcurlx added a commit that referenced this issue Feb 24, 2022
@ripcurlx
Merge pull request #6055 from ghubstan/1-prep-for-offer-service-proto…
4eada6f 
…-changes

Prepare API Offers .proto defs for significant changes [#1]
@terpii terpii mentioned this issue Mar 18, 2022
Closed
@carlosalbertofilho carlosalbertofilho mentioned this issue Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in:network
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cbeams @wofugangu @ManfredKarrer @notmandatory