Hide text that is not applicable in take offer view #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When taking an offer that does not specify an amount range, hide the "Check if offer is available" text. Fixes bisq-network#1742
Stop the offerAvailabilityBusyAnimation sooner, prior to showing securityDepositInfo popup, when it is hiding related fields.
ManfredKarrer
suggested changes
Oct 15, 2018
There was a problem hiding this comment.
NACK.
I added more background info in #1742. We must not hide is but change the layout so that it is better visible to the user and update the button states so that the user does not fund his wallet before the offer availibility check is successfully completed.
|
@ManfredKarrer A fixed amount offer now waits until the offer has been confirmed to be available, as shown below: Once confirmed, it will show the fund trade fields: |
|
A cool! Looks good to me! @ripcurlx - What do you think? I leave it to you to review/merge. |
ManfredKarrer
approved these changes
Oct 16, 2018
ripcurlx
approved these changes
Oct 17, 2018
|
I'll merge it although Travis fails as it is related to the current Java 10 JDK not loaded issue. |
This was referenced Oct 30, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When taking an offer that does not specify an amount range, "Check if offer is available" text was being displayed when it shouldn't be.
It was explicitly hiding the offerAvailabilityBusyAnimation, but not the offerAvailabilityLabel.
Fixes #1742