Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vwap bsq price #4098

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Add vwap bsq price #4098

merged 3 commits into from
Mar 31, 2020

Conversation

sqrrm
Copy link
Member

@sqrrm sqrrm commented Mar 29, 2020

Added a volume weighted average USD price to the BSQ facts and figures dashboard. The current 90/30 days average calculation is a BSQ/BTC calculation that doesn't take the USD price at time of trade into account.

Also cleaned up some unused code

@ripcurlx
Copy link
Contributor

@sqrrm
Copy link
Member Author

sqrrm commented Mar 31, 2020

@sqrrm please have a look at https://app.codacy.com/gh/bisq-network/bisq/pullRequest?prid=5265339 - thx!

Fixed

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Tested it on Mainnet and works as expected. Code looks fine as well.
Only drawback is that we now have a scrollbar in the Dashboard view.

Bildschirmfoto 2020-03-31 um 16 31 24

@ripcurlx ripcurlx merged commit 55048dc into bisq-network:master Mar 31, 2020
@sqrrm
Copy link
Member Author

sqrrm commented Mar 31, 2020

I didn't get the scroll bar, strange. Must have different window size for some reason.

@ripcurlx ripcurlx added this to the v1.3.0 milestone Apr 1, 2020
@sqrrm sqrrm deleted the add-VWAP-BSQ-price branch May 3, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants