Merge 4685 with 4680 #4686
Closed
Merge 4685 with 4680 #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly default value in case config is not set.
Simple monitor dumping json files with data result and request/response time to disk. Can be used by a simple web server to show state of seed nodes.
…a as well like DAO state Add more data to inventory map and change type of value to String.
…d nodes (monitor)
…es not make sense to limit requests). Add html output and webserver
Add average and color codes to html Add maxConnections Add DeviationSeverity enum Add custom seed node file Use InventoryItem as key in inventory map instead of string
Various improvements...
Various improvements...
Rearrange request info fields
Add all seeds
The monitor does not use the common bisq app base featuring guice. Hence, the `config` in the `Connection` class is never injected and leads to NullPointerExceptions and ultimately breaks the monitor. This workaround initilizes default values in case guice isn't there.
solved in another PR which we will add to that PR in next commits)
Apply code inspection
Merged
|
Replaced by #4695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will rebase and after #4685 and #4680 is merged.