-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor api test fixture setup #4724
Commits on Oct 23, 2020
-
Block on tx-fee-request in core TakeOfferModel init
Added license comment too.
Configuration menu - View commit details
-
Copy full SHA for cb65de6 - Browse repository at this point
Copy the full SHA cb65de6View commit details
Commits on Oct 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ab20225 - Browse repository at this point
Copy the full SHA ab20225View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63cf436 - Browse repository at this point
Copy the full SHA 63cf436View commit details -
Replace static TradeUtil with singleton TradeUtil
The API is going to need some desktop trade utilities, which should be shared between :desktop and :core.api.
Configuration menu - View commit details
-
Copy full SHA for 296e4f9 - Browse repository at this point
Copy the full SHA 296e4f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccd3c99 - Browse repository at this point
Copy the full SHA ccd3c99View commit details
Commits on Oct 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 24ba921 - Browse repository at this point
Copy the full SHA 24ba921View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36ad137 - Browse repository at this point
Copy the full SHA 36ad137View commit details -
Refactor PendingTradesDataModel methods -> TradeUtil
Scope of this refactoring is small; more can be done, but the short term goal is to share trade util logic with core api. - Removed unused method getCurrencyCode() - Made minor style changes - Removed duplicated code block
Configuration menu - View commit details
-
Copy full SHA for 95bcb1e - Browse repository at this point
Copy the full SHA 95bcb1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbd7a31 - Browse repository at this point
Copy the full SHA bbd7a31View commit details -
Add getRole(tradeId) to core api
API users will need to see their role as maker/taker when looking at trade details. - Add getRole(trade) to TradeUtil. - Add getTradeRole(tradeId) to CoreApi, CoreTradesService. - Add role field to TradeInfo proto and its wrapper class.
Configuration menu - View commit details
-
Copy full SHA for 161dbad - Browse repository at this point
Copy the full SHA 161dbadView commit details -
Refactor CLI output formatting code & add trade formatter
- Move output column header specs to its own shared constants class. - Add new TradeFormat class for printing trade details in the console. - Print formatted trade in api trade tests -- to see output before using formatter in CLI (in next PR).
Configuration menu - View commit details
-
Copy full SHA for 3379376 - Browse repository at this point
Copy the full SHA 3379376View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8bc265 - Browse repository at this point
Copy the full SHA d8bc265View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31435bb - Browse repository at this point
Copy the full SHA 31435bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b23704 - Browse repository at this point
Copy the full SHA 2b23704View commit details -
Add boolean 'showcontract' argument to api's 'gettrade'
Optionally print the json contract for a given trade id.
Configuration menu - View commit details
-
Copy full SHA for a2b2923 - Browse repository at this point
Copy the full SHA a2b2923View commit details
Commits on Oct 26, 2020
-
Stub out api methods 'keepfunds', 'withdrawfunds'
This PR adds trade closing method stubs to keep funds in the Bisq wallet or send them to an external BTC wallet. - Add grpc protos - Add new methods to GrpcTradesService, CoreApi - Stub out implementations in CoreTradesService - Add methods to CLI
Configuration menu - View commit details
-
Copy full SHA for a8decaf - Browse repository at this point
Copy the full SHA a8decafView commit details -
Implement api methods 'keepfunds', 'withdrawfunds'
The CoreTradesService was refactored to work for newly added api methods: - keepfunds -- close trade, keep funds in bisq wallet - withdrawfunds -- close trade, withdraw funds to external btc wallet A getKey accessor was added to CoreWalletsService (needed by withdrawfunds impl).
Configuration menu - View commit details
-
Copy full SHA for a3631a0 - Browse repository at this point
Copy the full SHA a3631a0View commit details
Commits on Oct 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f1db254 - Browse repository at this point
Copy the full SHA f1db254View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8ae566 - Browse repository at this point
Copy the full SHA b8ae566View commit details -
Test trade closing api methods 'keepfunds' withdrawfunds'
Some refactoring of the api test case hierarchy is included in this commit.
Configuration menu - View commit details
-
Copy full SHA for 1e25be5 - Browse repository at this point
Copy the full SHA 1e25be5View commit details -
Fix apitest dummy payment acct init bug
This commit fixes non-trade tests broken by the last refactoring.
Configuration menu - View commit details
-
Copy full SHA for 2746b27 - Browse repository at this point
Copy the full SHA 2746b27View commit details -
Stub out canceloffer api method
The implementation will be added to CoreOffersService in the next PR.
Configuration menu - View commit details
-
Copy full SHA for 027a7d5 - Browse repository at this point
Copy the full SHA 027a7d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f1d4f8 - Browse repository at this point
Copy the full SHA 0f1d4f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b38507c - Browse repository at this point
Copy the full SHA b38507cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91a2e2c - Browse repository at this point
Copy the full SHA 91a2e2cView commit details
Commits on Oct 28, 2020
-
Upgrade jupiterVersion = '5.7.0'
This upgrades jupiter for all subprojects using this library, but it does not affect released code.
Configuration menu - View commit details
-
Copy full SHA for 8e51e1e - Browse repository at this point
Copy the full SHA 8e51e1eView commit details -
Improve apitest cmd line console logging
- Show full stack traces in console - Do use previously cached test outputs - Do not show skipped test name in console (too noisy) - Show test run summary, including number of skipped tests - Show note about skipped test info in the html report - Show link to html report on test SUCCESS
Configuration menu - View commit details
-
Copy full SHA for d6524bf - Browse repository at this point
Copy the full SHA d6524bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a05203 - Browse repository at this point
Copy the full SHA 2a05203View commit details -
Refactor api test fixture setup
- Remove dead code from AbstractLinuxProcess. - Make default dummy accts static in MethodTest. - Simplify gRPC stub creation, btc block generation, dispute agent registration, and dummy acct initialization in test case startup. - Make ExpectedProtocolStatus visible to scenario test pkg.
Configuration menu - View commit details
-
Copy full SHA for f61f148 - Browse repository at this point
Copy the full SHA f61f148View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8e55d2 - Browse repository at this point
Copy the full SHA e8e55d2View commit details