Add api method createcryptopaymentacct #5356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change supports creation of BSQ BLOCKCHAIN payment method accounts. - Added proto message defs to grpc.proto. - Added grpc server boilerplate to GrpcPaymentAccountsService. - Added server impl to CoreApi, CorePaymentAccountsService. - Added createcryptopaymentacct-help.txt. - Added CLI side support for new api method. - Added opt parsing unit tests to OptionParsersTest. This is the 1st PR in a series, with the goal of supporting the BTC/BSQ trading pair. Support for other crypto currency payment accounts will be added later.
wallclockbuilder
previously approved these changes
Mar 28, 2021
There was a problem hiding this comment.
ACK
./bisq-cli --password=xyz --port=9998 createcryptopaymentacct \ --account-name="My BSQ Account" \ --currency-code=BSQ \ --address=BmxdvDCer85sKFWGc5wWTk2JcmK13jWGZsJ
payment account saved
Name Currency Payment Method ID
My BSQ Account BSQ BLOCK_CHAINS 4222730d-802d-4c23-87ed-db096e6a696f
./bisq-cli --password=xyz --port=9998 createcryptopaymentacct \ --account-name="My BSQ Account" \ --currency-code=BSQ \ --address=wrongaddressr85sKFWGc5wWTk2JcmK13wrongaddress
Error: wrongaddressr85sKFWGc5wWTk2JcmK13wrongaddress is not a valid bsq address
- Added bool tradeInstant field to proto message def. - Adjusted core createcryptopaymentacct impl to new tradeInstant request param. - Adjusted cli side createcryptopaymentacct impl to new tradeInstant request param. - Fixed CliMain's takeoffer help text (was missing the --payment-account opt).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supports creation of
BSQBLOCKCHAINpayment method accounts.grpc.proto.GrpcPaymentAccountsService.CoreApi,CorePaymentAccountsService.createcryptopaymentacct-help.txt.OptionParsersTest.This is the 1st PR in a series, with the goal of supporting the BTC/BSQ trading pair. Support for other crypto currency payment accounts will be added later.