Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow default fee values in leniency check #5365

Merged
merged 1 commit into from Mar 28, 2021
Merged

Allow default fee values in leniency check #5365

merged 1 commit into from Mar 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 27, 2021

Increased leniency for default fee rates. Related to #5347
Added test to TxValidatorTest.java

Before:

BTC fee: 441000
UNDERPAID. Expected BTC fee: 1029000 sats , actual fee paid: 441000 sats
Taker tx validation : FAIL

After:

BTC fee: 441000
Leniency rule: the fee matches a different DAO parameter Expected BTC fee: 1029000 sats , actual fee paid: 441000 sats
Taker tx validation : SUCCESS

@ghost
Copy link
Author

ghost commented Mar 28, 2021

Tested on Mainnet.

wallclockbuilder
wallclockbuilder approved these changes Mar 28, 2021
View reviewed changes
Copy link
Contributor

@wallclockbuilder wallclockbuilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

@ripcurlx ripcurlx added this to the v1.6.1 milestone Mar 28, 2021
ripcurlx
ripcurlx approved these changes Mar 28, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit fd17c57 into bisq-network:master Mar 28, 2021
@ghost ghost mentioned this pull request Apr 2, 2021
Closed
@wallclockbuilder wallclockbuilder mentioned this pull request Apr 3, 2021
Closed
@wallclockbuilder wallclockbuilder mentioned this pull request Aug 1, 2021
Closed
@ghost ghost deleted the fee_validation_default_rate branch May 29, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ripcurlx @wallclockbuilder