Upgrade Java to v11 and JavaFX to v15 #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the gradle dependency to JavaFX 14. This brings to Bisq the latest JavaFX fixes and improvements, especially in the areas of UI performance, memory management and security. JavaFX can be upgraded independently of the JDK used to build the application, so this change is modular and does not affect other parts of the build process. Related / likely related to: bisq-network#350 bisq-network#2135 bisq-network#2509 bisq-network#3128 bisq-network#3307 bisq-network#3308 bisq-network#3343 bisq-network#3430 bisq-network#3657 bisq-network#3677 bisq-network#3683 bisq-network#3686 bisq-network#3786 bisq-network#3787 bisq-network#3892 bisq-network#3917 bisq-network#3918 bisq-network#3936
Use java 14 to build the necessary artifacts. This is the most recent version which brings support for JavaFX 14, as well as a newer packager tool to build native applications.
Use Gradle 6.3, which adds support for Java 14.
Use Lombok v1.18.12, which adds support for Java 14.
Use Mockito 3.3.0, which fixes some bugs that caused valid tests to fail in the Java 14 environment.
Remove duplicate call to a stubbed method. This caused an UnnecessaryStubbingException with Mockito's strict validation settings.
Split test into sub-tests in order to avoid mockito UnnecessaryStubbingExceptions. These exceptions occurred because of 3 ambiguous uses of "when().thenReturn()" in the same test. These calls were ambiguous, because the when() argument was identical and mockito did not check the thenReturn() arguments, which would have differentiated the calls. Splitting this test method into 4 test methods achieved this call differentiation.
Upgrade JavaFX to most recent release.
Upgraded Gradle to the latest version, which has better module-info support for the imported gradle dependencies.
Fix styling to match Codacy rules.
Fix styling to match Codacy rules.
Fix styling to match Codacy rules.
Fix styling to match Codacy rules.
Fix styling to match Codacy rules.
Updated the commons-lang3 version to the latest one, to avoid the existence of multiple versions used by different projects. Before, v3.8 was used in most projects and v3.9 was brought as a transitive dependency in pricenode. So both were used by different projects. With this commit, all projects use v3.11, since it is explicitly defined in build.gradle. This resolves an exception thrown by jdeps when trying to list the module dependencies of the desktop-vXYZ-SNAPSHOT-all.jar.
Fix styling to match Codacy rules.
Try out optional tag to check how it affects codacy behavior. [skip ci]
Include the application version number in the jar manifest. This makes it easier later on, in the packaging process, to programmatically retrieve the build version from a reliable source.
Extend the gradle script with tasks that use jpackage to generate Bisq binaries. The kind of binaries generated depend on the OS where this is executed. The packaging of binaries can be started by calling: ./gradlew --console=plain packageInstallers from the root project folder.
Update jfoenix to attempt to fix JavaFX NPEs.
Fix the logic used to determine the JDK 15 assets and download links. Pre-releases are now excluded, as well as openj9 binaries. The resulting assets are final releases of hotspot builds.
Update jpackage arguments such that a specific java version is packaged in the installers (in this case, v11).
The drawback of this is that the floating label on top of the Field is not properly left aligned anymore. A proper fix would mean more re-writing of the jFoenix library which would make it harder and harder to maintain for applying library updates.
Update build script to only build the dmg for macOS.
Fixed typo affecting jpackage option concatenation, where a missing "+" caused subsequent options to not be considered. Surround concatenated options with parentheses, to ensure such a typo in the future is marked as a syntax error, and therefore avoided.
Remove TODO, since previous argument concatenation fix addressed the issue (desktop and start menu shortcuts are created now).
Update macOS setup script to use the tiff image in the installer bundle, as this is the type of background image expected and included by jpackage. Convert Bisq-background.png to Bisq-background.tiff using imagemagick.
Backport bisq-network#4600 into this PR. Set `-Djdk.module.illegalAccess=deny` in order to reduce warning in startup logs.
Disable the java option because it causes issues in the resulting app if packaged with a recent Java Runtime (tested with Java 11, 14 and 15).
Convert the fat jar into a deterministic one before it is packaged in the generated installers.
Store the SHA-256 of the deterministic jar next to the generated binaries.
Explicitly set the permissions on the generated exe binary, which are required by the signtool.
Surround entire command in quotes, to avoid issues with cmd parsing for a command with custom flags and space-containing arguments (full path of the exe arg).
Remove superfluous comments about the Windows setup.
…e-javafax-14 # Conflicts: # build.gradle
Include a zip with the relevant libs for running on raspi. Place the zip in the generated binaries folder.
Needs to be either only executed on macOS or adapted to work with Windows as well
used for mobile notification pairing because of missing current macOS support by currently used webcam library
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.