Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require the DAO is enabled for traders #6403

Merged
merged 9 commits into from
Nov 4, 2022
Merged

Require the DAO is enabled for traders #6403

merged 9 commits into from
Nov 4, 2022

Commits on Nov 3, 2022

  1. Remove daoActivated options 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    008cfaa View commit details
    Browse the repository at this point in the history

  2. Remove if (DevEnv.isDaoActivated()) checks as isDaoActivated is alw… 

    …ays true

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    72d97b8 View commit details
    Browse the repository at this point in the history

  3. Remove if (!DevEnv.isDaoActivated()) checks as !isDaoActivated is a… 

    …lways false
    @HenrikJannsen
    HenrikJannsen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    3e99a11 View commit details
    Browse the repository at this point in the history

  4. Remove tertiary operator DevEnv.isDaoActivated() ? as isDaoActivat… 

    …ed is always true

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    80e7dc7 View commit details
    Browse the repository at this point in the history

  5. Remove if blocks with !DevEnv.isDaoActivated() and combined && as… 

    … isDaoActivated is always true the whole statement is always false

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    e8a9132 View commit details
    Browse the repository at this point in the history

  6. Remove DevEnv.isDaoActivated() from combined if statements with `&&… 

    …` as isDaoActivated is always true

In case of a `||` the statement gets removed as it always is true.
At getUserPaymentAccounts we refactor further the steam to a HashSet constructor operation as the filter method gets removed.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    114bda2 View commit details
    Browse the repository at this point in the history

  7. Remove DevEnv.isDaoActivated method as not used anymore 

    Remove daoActivatedToggleButton from PreferencesView and NewsView

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    b5df4af View commit details
    Browse the repository at this point in the history

  8. Fix wrong rowSpan values (was bug in current version) 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    8d0b0be View commit details
    Browse the repository at this point in the history

  9. Fix param in test 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    e653262 View commit details
    Browse the repository at this point in the history