Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust burn target #6463

Merged
merged 19 commits into from
Dec 19, 2022
Merged

Adjust burn target #6463

merged 19 commits into from
Dec 19, 2022

Commits on Dec 14, 2022

  1. Add check for price==0 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2535f01 View commit details
    Browse the repository at this point in the history

  2. Remove try catch. Will be handled in Future fault handler 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    f799e11 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Change burn target calculation. 

    Left side is amount to burn to reach the max allowed receiver share based on the burned amount of all BM.
The right side is the amount to burn to reach the max allowed receiver share based the boosted max burn target.

Increase ISSUANCE_BOOST_FACTOR from 3 to 4.

Add help overlay to burn target table header.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    4860c11 View commit details
    Browse the repository at this point in the history

  2. In case we have capped burn shares we redistribute the share from the… 

    … over-burned amount to the non capped candidates.

This helps to avoid that the legacy BM would get the rest in case there are capped shares.
It still can be that a candidate exceeds the cap and by the adjustment becomes capped. We take that into account and the legacy BM would get some share in that case.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d0539e1 View commit details
    Browse the repository at this point in the history

  3. Don't allow the myBurnAmount to be larger than the upperBaseTarget 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    7f73ef7 View commit details
    Browse the repository at this point in the history

  4. Refactor: move out fields used the same way in both if/else branches. 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d585456 View commit details
    Browse the repository at this point in the history

  5. Add custom handling of legacy BM. 

    Refactoring: rename variables

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    0a941c1 View commit details
    Browse the repository at this point in the history

  6. Remove regtest value for DEFAULT_ESTIMATED_BTC_TRADE_FEE_REVENUE_PER_… 

    …CYCLE

Adjust reimbursement amounts as we do not reimburse 100% of the DPT

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6fd68f7 View commit details
    Browse the repository at this point in the history

  7. Remove numIssuance and numBurnOutputs columns to save space 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3ac6921 View commit details
    Browse the repository at this point in the history

  8. Use static fields for opReturnData instead of hardcoded mainnet hashes 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    57147a6 View commit details
    Browse the repository at this point in the history

  9. Update BurningManAccountingStore_BTC_MAINNET 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    decd301 View commit details
    Browse the repository at this point in the history

  10. Add new average bsq price after historical data 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2012c9d View commit details
    Browse the repository at this point in the history

  11. Increase GENESIS_OUTPUT_AMOUNT_FACTOR and ISSUANCE_BOOST_FACTOR 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5dd82d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Add balance fields for DAO revenue with total burned BSQ and total di… 

    …stributed BTC/BSQ

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    b5dbce4 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2022

  1. Exclude legacy BM from DAO balance 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    9efab7e View commit details
    Browse the repository at this point in the history

  2. Add sanity check that max share of a non-legacy BM is 20% over MAX_BU… 

    …RN_SHARE (taking into account potential increase due adjustment)

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    7237297 View commit details
    Browse the repository at this point in the history

  3. Add sanity check for a min. block height for the snapshot height 

    We don't allow to get further back than 767950 (the block height from Dec. 18th 2022)

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    c36c9b2 View commit details
    Browse the repository at this point in the history

  4. Fix test 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    2a8d1b3 View commit details
    Browse the repository at this point in the history

  5. Add INVALID_SNAPSHOT_HEIGHT to AvailabilityResult. 

    Use AvailabilityResult.INVALID_SNAPSHOT_HEIGHT instead of AckMessage with error.
Show description in error popup instead of enum name.
Return PRICE_CHECK_FAILED instead of UNKNOWN_FAILURE at error at price check also for non api users.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    21541d6 View commit details
    Browse the repository at this point in the history