Permit listening to version messages #35

dmos62 · 2020-03-30T13:47:28Z

Commit message for commit titled "Add listener for when a VersionMessage is received" explains the purpose of the PR in general:

Since Bisq requires nodes with specific configuration (as reflected in
their version messages), we also want to handle misconfigured nodes,
especially in cases where the user expects that node to be used. To get
access to all received version messages, a new listener is introduced.
Existing listeners are not sufficient, because in some cases BitcoinJ
will kill the Peer (connection to a node) before any of them are
triggered. This listener will always be triggered when a VersionMessage
is received.

In total, this PR introduces a bugfix (Permit alerts during handshake, see bisq-network/bisq#4080), a compilation breaking fix (Fix javadoc compilation on JDK 11), a new listener (Add listener for when a VersionMessage is received) and bumps the version number (0.14.7.bisq.1-SNAPSHOT -> 0.14.7.bisq.2-SNAPSHOT).

It should be noted that there is a failing test (not resulting from this PR): ChannelConnectionTest.testChannelResume:459->roundTripClientWallet:551 » IllegalState.

…iptType.

- Use Ubuntu Xenial (16.04) image. - Add an OpenJDK 11 build. - Drop Oracle JDK build. - Exclude wallettemplate from build, because of the dreaded OpenJFX dependency.

…d() and upgradeToDeterministic() for compatibility.

…bility.

… return keys/addresses of all active chains.

…key/address after new chain was activated.

…nto the sighash and old serialization is forced.

…ure() for consistency.

… seed words to work around the inability of Gradle to pass proper command line arguments.

…old.

In commit bc46e85, those two occurences of scriptCode building have been missed. cherry pick bitcoinj@7c31dcb

cherry pick bitcoinj@f92124d

…al transaction size. cherry pick bitcoinj@c97ecf6

cherry pick bitcoinj@2fc1b11

Fee is now specified in virtual (kilo)bytes. For non-segwit transactions a virtual byte is the same as a byte so the change is backward compatible. cherry pick bitcoinj@c168e67

Cherry pick bitcoinj@67034e6

Cherry pick bitcoinj@9267e71 This is to prevent a memory leak of pendingTxDownloads.

Cherry pick bitcoinj@29f450b

This reverts commit 12beae6.

Fixes bitcoinj#2070 (comment)

This keeps an erronious protocol exception from being thrown if an alert message is received before a version message is received. Fixes bisq-network/bisq#4080

dmos62 · 2021-02-03T22:35:09Z

Oh, this PR is merging into the wrong branch. I'll resubmit.

Andreas Schildbach and others added 30 commits February 14, 2019 20:34

If possible, use generic type inference for constructing objects.

0bd65ea

build.gradle: Configure Eclipse plugin.

34e8bc2

Update protobuf-gradle-plugin to 0.8.6.

b5517a1

Update Guava to 27.0.1-android.

f24a4aa

Update OkHttp to 3.12.1.

d4da021

Update protobuf-java to 3.6.1.

225941d

Update jopt-simple to 5.0.4.

08bb331

Wallet: In maybeRotateKeys(), fix logic to find out the preferred scr…

3dbc7ec

…iptType.

DeterministicKeyChain: Implement toString().

18e79b5

SPVBlockStoreTest: Fix missing close().

aec74e3

Update AUTHORS from git.

fc3d86b

.travis.yml: Bring up to date.

4fb0e6e

- Use Ubuntu Xenial (16.04) image. - Add an OpenJDK 11 build. - Drop Oracle JDK build. - Exclude wallettemplate from build, because of the dreaded OpenJFX dependency.

build.gradle: Print failed tests a bit more detailed.

66d54c1

Wallet: Add back deprecated variants of isDeterministicUpgradeRequire…

4de860a

…d() and upgradeToDeterministic() for compatibility.

Wallet: Add back deprecated variant of isPubKeyHashMine() for compati…

f11667f

…bility.

Wallet: Add back deprecated findKeyFromPubHash() for compatibility.

d6513a3

TransactionTest: Add a couple of asserts for transaction size.

1852ba7

GetDataMessage: Support fetching of blocks with witnesses.

8910cd7

Block: In toString(), print newline between transactions.

b303490

Wallet: Add an assert calculateFee().

30297af

Script: Fix getNumberOfBytesRequiredToSpend() for P2WPKH.

0317c19

Transaction: In toString(), move purpose up.

214e835

Wallet: Fix a reference in JavaDoc.

23e6862

Migrate usage of deprecated Transaction.getHash() to getTxId().

f94f8cd

Wallet: Fix getIssuedReceiveKeys() and getIssuedReceiveAddresses() to…

d7b2bea

… return keys/addresses of all active chains.

KeyChainGroup: Fix currentKey() and currentAddress() still vends old …

e68a24e

…key/address after new chain was activated.

Transaction: Fix hashForSignature() by making sure no witnesses get i…

ff76b50

…nto the sighash and old serialization is forced.

Transaction: Rename hashForSignatureWitness() to hashForWitnessSignat…

4af38b8

…ure() for consistency.

Wallet-tool: Allow comma, semicolon and double colon as separator for…

d7d6c3d

… seed words to work around the inability of Gradle to pass proper command line arguments.

DeterministicKeyChain: In toString(), print lookahead size and thresh…

2502847

…old.

schildbach and others added 25 commits October 15, 2020 11:53

Transaction, LocalTransactionSigner: Fix P2WPKH signing.

1f6ee08

In commit bc46e85, those two occurences of scriptCode building have been missed. cherry pick bitcoinj@7c31dcb

Add TransactionWitness.redeemP2WSH()

3e2fac7

cherry pick bitcoinj@f92124d

Set version to 0.15.8.bisq.8

fcec3da

Transaction: Add methods for calculating transaction weight and virtu…

2824953

…al transaction size. cherry pick bitcoinj@c97ecf6

Transaction: Move sizes to top in toString(), and print the weight too.

be766f0

cherry pick bitcoinj@2fc1b11

Wallet: Implement witness fee discount.

3f1b3fd

Fee is now specified in virtual (kilo)bytes. For non-segwit transactions a virtual byte is the same as a byte so the change is backward compatible. cherry pick bitcoinj@c168e67

Transaction: Fix missing newline in toString().

f4a4533

Cherry pick bitcoinj@67034e6

Set version to 0.15.8.bisq.9

60b4f2f

Peer: Disconnect peers that doesn't send announced transactions.

b9d95ce

Cherry pick bitcoinj@9267e71 This is to prevent a memory leak of pendingTxDownloads.

Peer: Disconnect remote peers which repeatedly don't respond to pings.

f9bfede

Cherry pick bitcoinj@29f450b

Set maxStalls to 10

3425c14

Disconnect peer if sending too many txs per block

6bbed06

Set version to 0.15.8.bisq.10

7752cb7

Use FilterRecalculateMode.SEND_IF_CHANGED

12beae6

Set version to 0.15.8.bisq.11

19c99da

Readd return statement removed by mistake

a3924ae

Set version to 0.15.8.bisq.12

dcf8af0

Revert "Use FilterRecalculateMode.SEND_IF_CHANGED"

902679f

This reverts commit 12beae6.

Update bloom filter if coins were sent

1a786a2

Fixes bitcoinj#2070 (comment)

Include in the filter ouputs that are spent

bc8d2e7

Fixes bitcoinj#2070 (comment)

Set version to 0.15.8.bisq.13

2a80db4

Bump version string

afa6202

Add VersionMessage received listener

1f5bd62

Account for early AlertMessage receival

42b32f6

This keeps an erronious protocol exception from being thrown if an alert message is received before a version message is received. Fixes bisq-network/bisq#4080

Fix javadoc comment

c29537c

dmos62 marked this pull request as draft February 3, 2021 15:45

dmos62 force-pushed the permit-listening-to-version-messages branch from 677f2dc to c29537c Compare February 3, 2021 15:48

dmos62 closed this Feb 3, 2021

dmos62 mentioned this pull request Feb 4, 2021

Permit listening to version messages #36

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Permit listening to version messages #35

Permit listening to version messages #35

dmos62 commented Mar 30, 2020 •

edited

Loading

dmos62 commented Feb 3, 2021

Permit listening to version messages #35

Permit listening to version messages #35

Conversation

dmos62 commented Mar 30, 2020 • edited Loading

dmos62 commented Feb 3, 2021

dmos62 commented Mar 30, 2020 •

edited

Loading