Bouncy castle 1.67 upgrade #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
napoly
force-pushed
the
bouncy-castle-1.67-upgrade
branch
5 times, most recently
from
dda1c63
to
976e9da
Compare
Co-authored-by: Andreas Schildbach <andreas.schildbach@bloq.com> Co-authored-by: Sean Gilligan <sean@msgilligan.com>
Co-authored-by: Andreas Schildbach <andreas@schildbach.de>
The reason is BouncyCastle 1.64 removed point compression tracking. Co-authored-by: Peter Dettman <peter.dettman@gmail.com>
napoly
force-pushed
the
bouncy-castle-1.67-upgrade
branch
2 times, most recently
from
d63b7ce
to
3ec95e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should resolve bisq-network/bisq#4163
should resolve bisq-network/bisq#6128
I tried to keep the changes atomic in separated commits with co-authors.. went with the lowest friction needed. Build for windows in Github Actions needs leveldbjni64-1.8 which is not really needed for our goal I believe..
The commits
ECKey: Add helper method isPubKeyCompressed(), and use it.andTrack point compression in LazyECPoint, rather than ECPoint.are basically cherry picks from upstream bitcoinj@7eb9c73 and bitcoinj@7629677..once merged it should be relatively easy to upgrade Bisq main app.....