Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Cycle 21 #774

Closed
stejbac opened this issue Jan 28, 2021 · 7 comments
Closed

For Cycle 21 #774

stejbac opened this issue Jan 28, 2021 · 7 comments
Assignees
@ripcurlx
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone
Cycle 21

Comments

@stejbac
Copy link

stejbac commented Jan 28, 2021 •
edited
Loading

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 800.00
  • USD requested: 600
  • BSQ rate: 0.75 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 19 #726

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Add taker check for deposit amount dev 300 bisq-network/bisq#4860 Part of cycle 20
Fix request amount bounds in ReimbursementValidator dev 250 bisq-network/bisq#5077
Avoid reverse DNS lookup in BtcNodeConverterTest dev 50 bisq-network/bisq#5083

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Implement Segwit for BSQ dev bisq-network/bisq#5000 Mostly reviewed & awaiting merge post-1.5.5 release - additionally plan to fork jsonrpc4j lib
Wallet changes for Segwit BSQ implementation dev bisq-network/bisq#5109 Awaiting review
Speed up deposit and transactions view loads dev bisq-network/bisq#5120 Awaiting review
Fix stale trade statistics list view when new entries arrive dev bisq-network/bisq#5122 Awaiting review
@stejbac stejbac changed the title [WIP] For Cycle 21 For Cycle 21 Jan 28, 2021
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Jan 28, 2021
@chimp1984
Copy link

I consider the value of your contributions much higher as what you are requesting for. Specially #4860 was a very important fix (even technically fixed earlier already).

@MwithM MwithM added this to the Cycle 21 milestone Jan 28, 2021
@sqrrm
Copy link
Member

sqrrm commented Jan 28, 2021

@stejbac I agree with @chimp1984 here. You really should ask for a lot more for these valuable contributions.

@stejbac
Copy link
Author

stejbac commented Jan 28, 2021

OK, I'll amend the request. (I wasn't sure about #4860 as I had already claimed compensation for the earlier effective fix.)

@ripcurlx
Copy link
Contributor

As team lead I approve this request for dev.

@stejbac
Copy link
Author

stejbac commented Jan 31, 2021

Tx ID: cc405b54a8992065cc32a04578e7c2d35af0b7ddb3eee3cda6b452867ec07d30

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Feb 10, 2021
@ghost
Copy link

ghost commented Feb 10, 2021

Issuance by Team:

team amount BSQ amount USD
dev 800.00 600.00

Total Issuance: 800.00 BSQ (equivalent to: 600.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Feb 10, 2021

Closed as accepted.

@MwithM MwithM closed this as completed Feb 10, 2021
@stejbac stejbac mentioned this issue Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Request Board
Archived in project
Milestone
Cycle 21
Development

No branches or pull requests
5 participants
@ripcurlx @sqrrm @MwithM @chimp1984 @stejbac