Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting custom status levels #102

Merged
merged 1 commit into from
Feb 15, 2016
Merged

Supporting custom status levels #102

merged 1 commit into from
Feb 15, 2016

Conversation

cressie176
Copy link

I'd like to downgrade successful responses to "debug" so I can filter them out from our logstash transport, while retaining our own info messages. This PR allows users to set the log level for successes, warnings and errors

@floatingLomas
Copy link
Collaborator

This looks fine to me, but please squash your commits first.

@rosston
Copy link
Collaborator

rosston commented Feb 15, 2016

Thanks for contributing! I like the idea, and it looks good to me too. But please add tests and update the README to document the new feature as well. I think for the documentation, you can just specify another possible value for statusLevels in the Options section.

@cressie176
Copy link
Author

Thanks for considering. No problem squashing commits or updating the README. I'll have a look at the tests too. There's nothing existing for the statusLevel feature to base them on so not sure how easy they'll be.

@rosston
Copy link
Collaborator

rosston commented Feb 15, 2016

That's actually a fair point about the tests. @floatingLomas has contemplated refactoring them in #60, and I've been thinking about it as well.

They're pretty messy as is. Maybe feel free to skip adding tests? I can add tests post-merge. And maybe that'll motivate me to finally tackle refactoring the tests. :)

@cressie176
Copy link
Author

OK. Commits squashed and readme updated.

@bithavoc
Copy link
Owner

👍

bithavoc added a commit that referenced this pull request Feb 15, 2016
Supporting custom status levels
@bithavoc bithavoc merged commit ee5d96d into bithavoc:master Feb 15, 2016
rosston pushed a commit that referenced this pull request Feb 17, 2016
nwah pushed a commit to nwah/express-winston that referenced this pull request Mar 1, 2016
@rosston
Copy link
Collaborator

rosston commented Mar 9, 2016

Sorry, I forgot to publish on npm after this first got merged. Now published in v1.3.0.

@cressie176
Copy link
Author

No problems. I've done that so many times it's not funny!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants