-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting custom status levels #102
Conversation
This looks fine to me, but please squash your commits first. |
Thanks for contributing! I like the idea, and it looks good to me too. But please add tests and update the README to document the new feature as well. I think for the documentation, you can just specify another possible value for |
Thanks for considering. No problem squashing commits or updating the README. I'll have a look at the tests too. There's nothing existing for the statusLevel feature to base them on so not sure how easy they'll be. |
That's actually a fair point about the tests. @floatingLomas has contemplated refactoring them in #60, and I've been thinking about it as well. They're pretty messy as is. Maybe feel free to skip adding tests? I can add tests post-merge. And maybe that'll motivate me to finally tackle refactoring the tests. :) |
OK. Commits squashed and readme updated. |
👍 |
Supporting custom status levels
Sorry, I forgot to publish on npm after this first got merged. Now published in v1.3.0. |
No problems. I've done that so many times it's not funny! |
I'd like to downgrade successful responses to "debug" so I can filter them out from our logstash transport, while retaining our own info messages. This PR allows users to set the log level for successes, warnings and errors