Add meta options to logging and error logging. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te logging options from error logging options. Add baseMeta and metaField to better control how meta is send to winston, allowing better logging features when using external logger as loggly. Corrects minor typo in test-coverage script command at package.json. Add tests for the metaField option.
|
So this allows you to define meta constants that get included with every log message, and to also allow moving the response data from the original meta to a specific property within the meta? |
|
Yes for both. Sorry for my English. |
|
Thank you. This PR actually helped me to understand the configuration better |
bithavoc
added a commit
that referenced
this pull request
Dec 2, 2015
Add meta options to logging and error logging.
|
Thank you @conradoqg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organizes the Readme.md, puts logging before error logging and separate logging options from error logging options.
Add baseMeta and metaField to better control how meta is send to winston, allowing better logging features when using external logger as loggly.
Corrects minor typo in test-coverage script command at package.json.
Add tests for the metaField option.