feat: fix empty link issue, contrast errors, set document lang to nb …

…and remove redudant alt text
bjerkio · Jul 3, 2023 · d2b8c35 · d2b8c35
1 parent 3d8e2fa
commit d2b8c35
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/src/app.html b/src/app.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html lang="en">
+<html lang="nb">
 	<head>
 		<meta charset="utf-8" />
 		<link rel="icon" href="%sveltekit.assets%/favicon.ico" />

diff --git a/src/components/employee.svelte b/src/components/employee.svelte
@@ -44,7 +44,7 @@
 />
 
 <div class="employee">
-	<Image src={image} class="profile-image" alt={name} />
+	<Image src={image} class="profile-image" alt="" />
 	<div class="section">
 		<div class="intro">
 			<p class="name">{name}</p>
@@ -58,10 +58,28 @@
 			<ul class="social-media-links">
 				{#each socialMedia as link}
 					{#if link.type == 'linkedin'}
-						<li><a href={link.url} target="_blank" rel="noopener"><LinkedinLogo /></a></li>
+						<li>
+							<a
+								href={link.url}
+								target="_blank"
+								rel="noopener"
+								aria-label={`Gå til LinkedIn-profilen til ${name}`}
+							>
+								<LinkedinLogo />
+							</a>
+						</li>
 					{/if}
 					{#if link.type == 'github'}
-						<li><a href={link.url} target="_blank" rel="noopener"><GithubLogo /></a></li>
+						<li>
+							<a
+								href={link.url}
+								target="_blank"
+								rel="noopener"
+								aria-label={`Gå til GitHub-profilen til ${name}`}
+							>
+								<GithubLogo />
+							</a>
+						</li>
 					{/if}
 				{/each}
 			</ul>
@@ -97,7 +115,7 @@
 		}
 
 		.position {
-			color: var(--dark60);
+			color: var(--dark80);
 		}
 	}