Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add single product page #562

Merged
merged 4 commits into from
Jun 19, 2023
Merged

feat: add single product page #562

merged 4 commits into from
Jun 19, 2023

Conversation

simenandre
Copy link
Member

No description provided.

braaar
braaar approved these changes Jun 19, 2023
View reviewed changes
src/data/sanity-client-browser.ts Show resolved Hide resolved
moripen
moripen reviewed Jun 19, 2023
View reviewed changes
Copy link
Contributor

@moripen moripen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you post a screenshot to showcase the changes on the website? It was a bit hard to get an overview of how this would look in my head.

.npmrc Show resolved Hide resolved
src/data/projects/get-projects.ts Outdated Show resolved Hide resolved
@simenandre
Copy link
Member Author

Could you post a screenshot to showcase the changes on the website? It was a bit hard to get an overview of how this would look in my head.

The pages are not linked to, so the visual aspect of it can be seen once it's landed.

@simenandre @moripen
Update src/data/projects/get-projects.ts
3a1e9cd 
Co-authored-by: moripen <107696180+moripen@users.noreply.github.com>
@simenandre simenandre merged commit 62d8f2d into main Jun 19, 2023
1 check passed
@simenandre simenandre deleted the simenandre/add-product-single branch June 19, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moripen moripen moripen left review comments

@braaar braaar braaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simenandre @braaar @moripen