Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6 breakdown pt2 - add common module #17

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

ribeirojose
Copy link

@ribeirojose ribeirojose commented Apr 25, 2024

original PR: cowdao-grants#6

Copy link

linear bot commented Apr 25, 2024

COW-2 mfw87 feedbacks

@ribeirojose ribeirojose changed the title #6 breakdown pt3 - add common module #6 breakdown pt2 - add common module Apr 25, 2024
SEPOLIA = 11155111
MAINNET = (1, "ethereum", "https://etherscan.io")
GNOSIS = (100, "gnosis", "https://gnosisscan.io")
SEPOLIA = (11155111, "sepolia", "https://sepolia.etherscan.io/")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this trailing slash cause issues?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that we've noticed, but good catch!

@ribeirojose ribeirojose merged commit 0e71a35 into cow-1-codegen May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants