Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone2 #12

Merged
merged 25 commits into from
Feb 20, 2023
Merged

Milestone2 #12

merged 25 commits into from
Feb 20, 2023

Conversation

rubenguc
Copy link
Collaborator

@rubenguc rubenguc commented Feb 13, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
@rubenguc rubenguc requested review from a team as code owners February 13, 2023 21:47
rubenguc and others added 8 commits February 13, 2023 18:39
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
Signed-off-by: Ruben <rubdeivis@gmail.com>
0xslipk
0xslipk previously approved these changes Feb 20, 2023
Copy link
Member

@0xslipk 0xslipk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xslipk 0xslipk merged commit ef5a244 into main Feb 20, 2023
@0xslipk 0xslipk deleted the milestone2 branch February 20, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants