Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu lightning labels #1910

Merged
merged 13 commits into from
May 27, 2024
Merged

Menu lightning labels #1910

merged 13 commits into from
May 27, 2024

Conversation

maxaleks
Copy link
Collaborator

@maxaleks maxaleks commented May 13, 2024

Description and Related Issue(s)

Resolves #1776

Adds a new env var NEXT_PUBLIC_MENU_LIGHTNING_LABELS

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@maxaleks maxaleks requested review from tom2drum and isstuev May 13, 2024 15:27
docs/ENVS.md Outdated Show resolved Hide resolved
public/icons/name.d.ts Outdated Show resolved Hide resolved
ui/snippets/navigation/LightningLabel.tsx Outdated Show resolved Hide resolved
ui/snippets/navigation/useLightningLabel.ts Outdated Show resolved Hide resolved
@tom2drum tom2drum merged commit fbf6944 into main May 27, 2024
7 checks passed
@tom2drum tom2drum deleted the menu-lightning-label branch May 27, 2024 16:37
@JOY
Copy link

JOY commented May 29, 2024

It could be great if you guys can add an example/image for the new/changed env for every update.

@tom2drum
Copy link
Collaborator

@JOY example values you always can find in the ./docs/ENVS.md file
Not sure about the images though, we will think about it. Maybe we will the examples to the same file where it is applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ENVs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a lightning label to the side menu
3 participants