Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error if contract method has invalid data structure #2087

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

tom2drum
Copy link
Collaborator

@tom2drum tom2drum commented Jul 9, 2024

Description and Related Issue(s)

When a contract method has an invalid data structure (e.g., no outputs property), we display an alert within its accordion section instead of a generic 500 error for the entire page.

Also, it fixes the issue with an invalid address error when reading a contract method.

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@tom2drum tom2drum merged commit 6f7c284 into main Jul 18, 2024
7 checks passed
@tom2drum tom2drum deleted the tom2drum/abi-parsing-fixes branch July 18, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants